Clean-up relationships querying code. #2258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meistermeier
approved these changes
May 18, 2021
| boolean t2; | ||
| T t3; | ||
| final T t1; | ||
| final boolean t2; |
There was a problem hiding this comment.
Because it got touched again, can we please introduce some proper names for the fields in the tuple?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating #1907 provided a bit of opportunity to clarify the relationship mapping code a bit when deciding to use generic "find by id" queries vs. list projections.
While we can't implement 1907 as such, I would like to see this refactorings merged in main and 6.1