Skip to content

Change the nodes to be filtered by targetLabel #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Change the nodes to be filtered by targetLabel #2115

wants to merge 1 commit into from

Conversation

Jafeyyu
Copy link

@Jafeyyu Jafeyyu commented Jan 14, 2021

Change the nodes to be filtered by targetLabel from PATH_START&PATH_START to PATH_START&PATH_END.

  • You have read the Spring Data Neo4j contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Change the nodes to be filtered by targetLabel from PATH_START&PATH_START to PATH_START&PATH_END
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 14, 2021
@michael-simons
Copy link
Collaborator

Thanks a lot, @Jafeyyu As much as I would have liked to merge or cherry pick that into my branch with tests added, I cannot.

Of course I had that solution myself, but it turned out that we can simplify the path mapping by a magnitude without changing functionality. You will see in the solution to #2114.

@michael-simons michael-simons added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants