Skip to content

Refine DefaultNeo4jPersistentProperty.isEntity() and getPersistentEntityTypeInformation() checks #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Mar 11, 2024 · 0 comments
Closed

Refine DefaultNeo4jPersistentProperty.isEntity() and getPersistentEntityTypeInformation() checks #2869

mp911de opened this issue Mar 11, 2024 · 0 comments
Assignees
@mp911de
Labels
type: task A general task
Milestone
7.2.4 (2023.1.4)

Comments

@mp911de
Copy link
Member

mp911de commented Mar 11, 2024

Based on spring-projects/spring-data-commons#3056, type checks to include a property's type as entity require refinement to check against a registered converter since the entity detection mechanism in BasicPersistentProperty.getPersistentEntityTypeInformation() no longer uses isEntity() due to internal recursive calls.
@mp911de mp911de added the type: task A general task label Mar 11, 2024
@mp911de mp911de added this to the 7.2.4 (2023.1.4) milestone Mar 11, 2024
@mp911de mp911de self-assigned this Mar 11, 2024
mp911de added a commit that referenced this issue Mar 11, 2024
@mp911de
Skip entity detection for converted properties.
a1f4566 
DefaultNeo4jPersistentProperty.isEntity() and getPersistentEntityTypeInformation() now return that the property does not map to an entity if a converter is registered.

Closes #2869
@mp911de mp911de mentioned this issue Mar 11, 2024
Closed
meistermeier pushed a commit that referenced this issue Mar 11, 2024
@mp911de @meistermeier
Skip entity detection for converted properties.
6b56907 
DefaultNeo4jPersistentProperty.isEntity() and getPersistentEntityTypeInformation() now return that the property does not map to an entity if a converter is registered.

Closes #2869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: task A general task
Projects
None yet
Milestone
7.2.4 (2023.1.4)
Development

Successfully merging a pull request may close this issue.

Skip entity detection for converted properties spring-projects/spring-data-neo4j
1 participant
@mp911de