Skip to content

Improve label determination for inherited entities #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
meistermeier opened this issue Apr 13, 2021 · 0 comments
Closed

Improve label determination for inherited entities #2225

meistermeier opened this issue Apr 13, 2021 · 0 comments
Assignees
@meistermeier
Labels
type: enhancement A general enhancement
Milestone
6.0.8 (2020.0.8)

Comments

@meistermeier
Copy link
Collaborator

No description provided.

@meistermeier meistermeier self-assigned this Apr 13, 2021
@meistermeier meistermeier added this to the 6.0.8 (2020.0.8) milestone Apr 13, 2021
meistermeier added a commit that referenced this issue Apr 13, 2021
@meistermeier
GH-2225 - Prepare branch.
ece15a8
meistermeier added a commit that referenced this issue Apr 13, 2021
@meistermeier
GH-2225 - Improve label determination for inherited entities.
a378505
meistermeier added a commit that referenced this issue Apr 14, 2021
@meistermeier
GH-2225 - Polish test.
5b74b0c
meistermeier added a commit that referenced this issue Apr 14, 2021
@meistermeier
GH-2225 - Improve label determination for inherited entities.
d1782c0 
With multiple concrete implementations of an abstract class the
determination of the concrete node description for a result `n,
collect(r), collect(rn)` was flaky.
The abstract class' repository only gives its abstract label as an
anchor for the determination.
The initial mapping step looks through the whole result to figure the
labels for the "root node" but misses out to check for one node that
reflects the concrete initial "root node". This leads to the situation
that the concrete node description is getting randomly choosen from the
random set of possible candidates.

Closes #2225
@michael-simons michael-simons added the type: enhancement A general enhancement label Apr 14, 2021
meistermeier added a commit that referenced this issue Apr 14, 2021
@meistermeier
GH-2225 - Naive imperative solution.
9c041c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meistermeier meistermeier

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.8 (2020.0.8)
Development

No branches or pull requests
2 participants
@meistermeier @michael-simons