Skip to content

Provide a way for defining dynamic queries in a type safe way. #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Jul 27, 2020 · 1 comment
Closed

Provide a way for defining dynamic queries in a type safe way. #1911

spring-projects-issues opened this issue Jul 27, 2020 · 1 comment
Assignees
@michael-simons
Labels
type: enhancement A general enhancement
Milestone
6.1 M5 (2021.0.0)

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented Jul 27, 2020 •
edited by michael-simons
Loading

We can support the creation of dynamic and type safe queries with the following addition:

  • Use the Cypher-DSL 2021.1.0 Query-DSL support and provide a Neo4j specific implementation of QuerydslPredicateExecutor
  • Provide a native CypherdslConditionExecutor that has basically the same signatures as above, but Cypher-DSL conditions instead of Query-DSL predicates
  • Provide CypherdslStatementExecutor and ReactiveCypherdslStatementExecutor that works on full statements and also support projections.

Original ticket was DATAGRAPH-1349
@spring-projects-issues spring-projects-issues added the type: enhancement A general enhancement label Dec 31, 2020
@michael-simons michael-simons mentioned this issue Feb 1, 2021
Closed
@michael-simons
Copy link
Collaborator

Evaluate a way to provide something analog to QuerydslJpaPredicateExecutor and QuerydslJpaRepository like we seen in Spring Data JPA.

@michael-simons michael-simons changed the title Provide a way of defining custom queries in a static, type safe way. [DATAGRAPH-1349] Provide a way for defining dynamic queries in a type safe way. Mar 15, 2021
@michael-simons michael-simons linked a pull request Mar 15, 2021 that will close this issue
Provide a way for defining dynamic queries in a type safe way. #2184
Closed
@michael-simons michael-simons added this to the 6.1 M5 (2021.0.0) milestone Mar 15, 2021
michael-simons added a commit that referenced this issue Mar 22, 2021
@michael-simons
GH-1911 - Polishing.
fcf767a 
This changes the return types of the `CypherdslConditionExecutor` into `Collection` and aligns it with the `CypherdslStatementExecutor` and in the long run with the goal Spring Data Commons has for the `QuerydslPredicateExecutor`.  It makes more sense for this new API to align with the desired state instead of something we consider suboptimal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-simons michael-simons

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
6.1 M5 (2021.0.0)
Development

Successfully merging a pull request may close this issue.

Provide a way for defining dynamic queries in a type safe way. spring-projects/spring-data-neo4j
2 participants
@michael-simons @spring-projects-issues