GH-2234 - Move database selection into Runnable-Spec.

Fixes the problem that certain operations did not take the database
selection into consideration when executing queries.

Closes #2234

Author: meistermeier

src/main/java/org/springframework/data/neo4j/core/DefaultNeo4jClient.java

@@ -189,6 +189,7 @@ class DefaultRunnableSpec implements RunnableSpec {
 		private String targetDatabase;
 
 		DefaultRunnableSpec(Supplier<String> cypherSupplier) {
+			this.targetDatabase = Neo4jClient.verifyDatabaseName(resolveTargetDatabaseName(targetDatabase));
 			this.runnableStatement = new RunnableStatement(cypherSupplier);
 		}
 
@@ -257,6 +258,19 @@ public ResultSummary run() {
 				throw potentiallyConvertRuntimeException(e, persistenceExceptionTranslator);
 			}
 		}
+
+		private String resolveTargetDatabaseName(@Nullable String parameterTargetDatabase) {
+			if (parameterTargetDatabase != null) {
+				return parameterTargetDatabase;
+			}
+			if (databaseSelectionProvider != null) {
+				String databaseSelectionProviderValue = databaseSelectionProvider.getDatabaseSelection().getValue();
+				if (databaseSelectionProviderValue != null) {
+					return databaseSelectionProviderValue;
+				}
+			}
+			return DatabaseSelectionProvider.getDefaultSelectionProvider().getDatabaseSelection().getValue();
+		}
 	}
 
 	class DefaultRecordFetchSpec<T> implements RecordFetchSpec<T>, MappingSpec<T> {
@@ -270,24 +284,11 @@ class DefaultRecordFetchSpec<T> implements RecordFetchSpec<T>, MappingSpec<T> {
 		DefaultRecordFetchSpec(String parameterTargetDatabase, RunnableStatement runnableStatement,
 				BiFunction<TypeSystem, Record, T> mappingFunction) {
 
-			this.targetDatabase = resolveTargetDatabaseName(parameterTargetDatabase);
+			this.targetDatabase = parameterTargetDatabase;
 			this.runnableStatement = runnableStatement;
 			this.mappingFunction = mappingFunction;
 		}
 
-		private String resolveTargetDatabaseName(@Nullable String parameterTargetDatabase) {
-			if (parameterTargetDatabase != null) {
-				return parameterTargetDatabase;
-			}
-			if (databaseSelectionProvider != null) {
-				String databaseSelectionProviderValue = databaseSelectionProvider.getDatabaseSelection().getValue();
-				if (databaseSelectionProviderValue != null) {
-					return databaseSelectionProviderValue;
-				}
-			}
-			return DatabaseSelectionProvider.getDefaultSelectionProvider().getDatabaseSelection().getValue();
-		}
-
 		@Override
 		public RecordFetchSpec<T> mappedBy(
 				@SuppressWarnings("HiddenField") BiFunction<TypeSystem, Record, T> mappingFunction) {
@@ -358,7 +359,7 @@ class DefaultRunnableDelegation<T> implements RunnableDelegation<T>, OngoingDele
 
 		DefaultRunnableDelegation(Function<QueryRunner, Optional<T>> callback, @Nullable String targetDatabase) {
 			this.callback = callback;
-			this.targetDatabase = targetDatabase;
+			this.targetDatabase = Neo4jClient.verifyDatabaseName(targetDatabase);
 		}
 
 		@Override
@@ -375,4 +376,5 @@ public Optional<T> run() {
 			}
 		}
 	}
+
 }

src/test/java/org/springframework/data/neo4j/integration/imperative/RepositoryIT.java

@@ -4285,7 +4285,7 @@ public Neo4jMappingContext neo4jMappingContext(Neo4jConversions neo4JConversions
 		}
 
 		@Bean
-		public DatabaseSelectionProvider databaseNameProvider() {
+		public DatabaseSelectionProvider databaseSelectionProvider() {
 			return () -> databaseSelection;
 		}
 	}