Update list of supported query method keywords. #3950
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mihailcornescu
changed the title
|
|
||
| | `IgnoreCase` | ||
| | `findByUsernameIgnoreCase(String username)` | ||
| | `{"username" : {"$strcasecmp" : username }}` |
There was a problem hiding this comment.
$strcasecmp is an aggregation operator. The MongoQueryCreator uses a Pattern that translates to { $regex : '^username$', '$options' : 'i' }.
There was a problem hiding this comment.
Thank you for the feedback. I will make the changes.
There was a problem hiding this comment.
Hi @christophstrobl. I have made the changes. You were right, that regex is used in the code.
Is it ok to use double quotes instead of single quotes? I noticed that strings are used and even the i from the options is a String.
|
Thanks for the contribution @mihailcornescu! Merged to main development line and back ported to 3.3.x and 3.2.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3916.
@IgnoreCaseto mongodb.repositories.queries query table documentation.