Skip to content

Fix pagination using the reactive fluent Querydsl API #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rolag-it
Copy link
Contributor

Pageable object was not passed to Query, so fetchPage retrieved erroneously the whole dataset as Page content.

Pageable object was not passed to Query, so fetchPage retrieved erroneously the whole dataset as Page content.
@pivotal-cla
Copy link

@rolag-it Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 29, 2021
@pivotal-cla
Copy link

@rolag-it Thank you for signing the Contributor License Agreement!

@rolag-it rolag-it force-pushed the main branch 2 times, most recently from 98cea94 to 8dd6ab1 Compare December 7, 2021 17:35
@mp911de mp911de self-assigned this Jan 12, 2022
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 12, 2022
@mp911de mp911de added this to the 3.3.1 (2021.1.1) milestone Jan 12, 2022
@mp911de mp911de changed the title Fix pagination with reactive fluent Querydsl query definition . Fix pagination using the reactive fluent Querydsl API Jan 12, 2022
@mp911de
Copy link
Member

mp911de commented Jan 12, 2022

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Jan 12, 2022
mp911de pushed a commit that referenced this pull request Jan 12, 2022
Pageable object was not passed to Query, so fetchPage retrieved erroneously the whole dataset as Page content.

Closes #3892
mp911de added a commit that referenced this pull request Jan 12, 2022
Add author tags, extend copyright license years, simplify tests.

See #3892
mp911de pushed a commit that referenced this pull request Jan 12, 2022
Pageable object was not passed to Query, so fetchPage retrieved erroneously the whole dataset as Page content.

Closes #3892
mp911de added a commit that referenced this pull request Jan 12, 2022
Add author tags, extend copyright license years, simplify tests.

See #3892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants