-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fluent query API should use ProjectionFactory provided by the RepositoryFactory #3432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,4 +85,5 @@ public interface CrudMethodMetadata { | |
* @since 1.9 | ||
*/ | ||
Method getMethod(); | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
...java/org/springframework/data/jpa/repository/support/JpaRepositoryConfigurationAware.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Copyright 2024 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.springframework.data.jpa.repository.support; | ||
|
||
import org.springframework.data.jpa.repository.query.EscapeCharacter; | ||
import org.springframework.data.projection.ProjectionFactory; | ||
|
||
/** | ||
* Interface to be implemented by classes that want to be aware of their configuration in a JPA repository context. | ||
* | ||
* @author Mark Paluch | ||
* @since 3.2.6 | ||
*/ | ||
public interface JpaRepositoryConfigurationAware { | ||
|
||
/** | ||
* Configures the {@link EscapeCharacter} to be used with the repository. | ||
* | ||
* @param escapeCharacter must not be {@literal null}. | ||
*/ | ||
default void setEscapeCharacter(EscapeCharacter escapeCharacter) { | ||
|
||
} | ||
|
||
/** | ||
* Configures the {@link ProjectionFactory} to be used with the repository. | ||
* | ||
* @param projectionFactory must not be {@literal null}. | ||
*/ | ||
default void setProjectionFactory(ProjectionFactory projectionFactory) { | ||
|
||
} | ||
|
||
/** | ||
* Configures the {@link CrudMethodMetadata} to be used with the repository. | ||
* | ||
* @param metadata must not be {@literal null}. | ||
*/ | ||
default void setRepositoryMethodMetadata(CrudMethodMetadata metadata) { | ||
|
||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JpaRepositoryImplementation
provides already customization options for repository implementations. What if we evolve that concept by movingsetRepositoryMethodMetadata
andsetEscapeCharacter
methods into a new interface, that would also acceptProjectionFactory
and let both,JpaRepositoryImplementation
andQuerydslJpaPredicateExecutor
implement that interface?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth exploring - also in the light of having to deal with a similar arrangement in other store modules.