Description
We works with postgresql event I don't think it change something.
This was working fine until 2.6.4 (included).
We had a query with a param that should be null.
@Query("SELECT b FROM BenchmarkEntity b WHERE (:name is null or b.name like %:name%) "
"and (:reference is null or b.reference = :reference) ")
List<BenchmarkEntity> findBenchmarks(String name, Boolean reference);It avoids us to use a 'like' when the optional parameter 'name' is null.
Before 2.6.4, it returned all the tables rows.
With 2.7.0, it doesn't return any row => no match
The behaviour changed for the parameter pass to the sql query.
Before : 2.6.4 (working)
11:37:57.415 TRACE [,,] 33012 --- [ main] o.h.t.d.sql.BasicBinder : binding parameter [1] as [VARCHAR] - [null]
11:37:57.415 TRACE [,,] 33012 --- [ main] o.h.t.d.sql.BasicBinder : binding parameter [2] as [VARCHAR] - [null]
11:37:57.416 TRACE [,,] 33012 --- [ main] o.h.t.d.sql.BasicBinder : binding parameter [3] as [BOOLEAN] - [null]
11:37:57.416 TRACE [,,] 33012 --- [ main] o.h.t.d.sql.BasicBinder : binding parameter [4] as [BOOLEAN] - [null]
With 2.7.0 (broken):
11:48:41.547 TRACE [,,] 34086 --- [ main] o.h.t.d.sql.BasicBinder : binding parameter [1] as [VARCHAR] - [%org.hibernate.jpa.TypedParameterValue@78184e8c%]
11:48:41.547 TRACE [,,] 34086 --- [ main] o.h.t.d.sql.BasicBinder : binding parameter [2] as [VARCHAR] - [%org.hibernate.jpa.TypedParameterValue@78184e8c%]
11:48:41.548 TRACE [,,] 34086 --- [ main] o.h.t.d.sql.BasicBinder : binding parameter [3] as [BOOLEAN] - [null]
11:48:41.548 TRACE [,,] 34086 --- [ main] o.h.t.d.sql.BasicBinder : binding parameter [4] as [BOOLEAN] - [null]It seems that the bind value is the encapsulating instance (TypedParameterValue) instead of it's internal value, but only for String value (works with other types).
What is strange is that the QueryParameters object has a list of TypedValue (normal), and for the boolean, the value is 'null'
But for the String the value is not null but '%org.hibernate.jpa.TypedParameterValue@7eaf7a70%'
When I remove the 'contains' part in the query, the behaviour didn't change between the 2.6.4 and the 2.7.0, meaning it works fine with 2.7.0.
@Query("SELECT b FROM BenchmarkEntity b WHERE (:name is null) "
"and (:reference is null or b.reference = :reference) ")
List<BenchmarkEntity> findBenchmarks(String name, Boolean reference);11:37:57.415 TRACE [,,] 33012 --- [ main] o.h.t.d.sql.BasicBinder : binding parameter [1] as [VARCHAR] - [null]
11:37:57.416 TRACE [,,] 33012 --- [ main] o.h.t.d.sql.BasicBinder : binding parameter [2] as [BOOLEAN] - [null]
11:37:57.416 TRACE [,,] 33012 --- [ main] o.h.t.d.sql.BasicBinder : binding parameter [3] as [BOOLEAN] - [null]
That seems it's the fact that the param is use in a 'contains' clause change its value instead of the binding.