Skip to content

Commit e466cdb

Browse files
committed
DATAJPA-1818 - Ignoring tests for EclipseLink.
Handling of IN-Queries in Eclipselink is still broken.
1 parent 7f28d25 commit e466cdb

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,8 @@ public void deleteAllByIdInBatch(Iterable<ID> ids) {
255255
return;
256256
}
257257

258-
String queryString = String.format(DELETE_ALL_QUERY_BY_ID_STRING, entityInformation.getEntityName(), entityInformation.getIdAttribute().getName());
258+
String queryTemplate = DELETE_ALL_QUERY_BY_ID_STRING;
259+
String queryString = String.format(queryTemplate, entityInformation.getEntityName(), entityInformation.getIdAttribute().getName());
259260

260261
Query query = em.createQuery(queryString);
261262
query.setParameter("ids", ids);

src/test/java/org/springframework/data/jpa/repository/support/EclipseLinkJpaRepositoryTests.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.springframework.data.jpa.repository.support;
1717

18+
import org.junit.jupiter.api.Disabled;
1819
import org.springframework.test.context.ContextConfiguration;
1920

2021
/**
@@ -25,4 +26,11 @@
2526
@ContextConfiguration("classpath:eclipselink.xml")
2627
class EclipseLinkJpaRepositoryTests extends JpaRepositoryTests {
2728

29+
@Override
30+
/**
31+
* Ignored until https://bugs.eclipse.org/bugs/show_bug.cgi?id=349477 is resolved.
32+
*/
33+
void deleteAllByIdInBatch() {
34+
super.deleteAllByIdInBatch();
35+
}
2836
}

0 commit comments

Comments
 (0)