DATAJPA-1818 - Add JpaRepository.deleteAllByIdInBatch(Iterable<ID> ids).

Author: schauder

src/main/java/org/springframework/data/jpa/repository/JpaRepository.java

@@ -84,6 +84,19 @@ public interface JpaRepository<T, ID> extends PagingAndSortingRepository<T, ID>,
 	 */
 	void deleteInBatch(Iterable<T> entities);
 
+
+	/**
+	 * Deletes the entities identified by the given ids using a single {@link Query}.
+	 *
+	 * This kind of operation leaves JPAs first level cache and the database out of sync.
+	 * Consider flushing the `EntityManager` before calling this method.
+	 *
+	 * @param ids
+	 *
+	 * @since 3.0
+	 */
+	void deleteAllByIdInBatch(Iterable<ID> ids);
+
 	/**
 	 * Deletes all entities in a batch call.
 	 */

src/main/java/org/springframework/data/jpa/repository/query/QueryUtils.java

@@ -86,6 +86,7 @@ public abstract class QueryUtils {
 
 	public static final String COUNT_QUERY_STRING = "select count(%s) from %s x";
 	public static final String DELETE_ALL_QUERY_STRING = "delete from %s x";
+	public static final String DELETE_ALL_QUERY_BY_ID_STRING = "delete from %s x where %s in :ids";
 
 	// Used Regex/Unicode categories (see https://www.unicode.org/reports/tr18/#General_Category_Property):
 	// Z Separator

src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java

@@ -246,6 +246,23 @@ public void deleteInBatch(Iterable<T> entities) {
 				.executeUpdate();
 	}
 
+	@Override
+	public void deleteAllByIdInBatch(Iterable<ID> ids) {
+
+		Assert.notNull(ids, "Ids must not be null!");
+
+		if (!ids.iterator().hasNext()) {
+			return;
+		}
+
+		String queryString = String.format(DELETE_ALL_QUERY_BY_ID_STRING, entityInformation.getEntityName(), entityInformation.getIdAttribute().getName());
+
+		Query query = em.createQuery(queryString);
+		query.setParameter("ids", ids);
+
+		query.executeUpdate();
+	}
+
 	/*
 	 * (non-Javadoc)
 	 * @see org.springframework.data.repository.Repository#deleteAll()

src/test/java/org/springframework/data/jpa/repository/support/JpaRepositoryTests.java

@@ -114,11 +114,24 @@ void executesExistsForEntityWithIdClass() {
 		assertThat(idClassRepository.existsById(id)).isTrue();
 	}
 
-	private static interface SampleEntityRepository extends JpaRepository<SampleEntity, SampleEntityPK> {
+	@Test // DATAJPA-1818
+	void deleteAllByIdInBatch() {
+
+		SampleEntity one = new SampleEntity("one", "eins");
+		SampleEntity two = new SampleEntity("two", "zwei");
+		SampleEntity three = new SampleEntity("three", "drei");
+		repository.saveAll(Arrays.asList(one, two, three));
+		repository.flush();
+
+		repository.deleteAllByIdInBatch(Arrays.asList(new SampleEntityPK("one", "eins"),new SampleEntityPK("three", "drei")));
+		assertThat(repository.findAll()).containsExactly(two);
+	}
+
+	private interface SampleEntityRepository extends JpaRepository<SampleEntity, SampleEntityPK> {
 
 	}
 
-	private static interface SampleWithIdClassRepository
+	private interface SampleWithIdClassRepository
 			extends CrudRepository<PersistableWithIdClass, PersistableWithIdClassPK> {
 
 	}