DATAES-976 - Implement CrudRepository.delete(Iterable<ID> ids). #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Nov 19, 2020
| @@ -107,7 +109,7 @@ public void saveShouldSaveSingleEntity() { | |||
| public void saveShouldComputeMultipleEntities() { | |||
|
|
|||
| repository | |||
| .saveAll(Arrays.asList(SampleEntity.builder().build(), SampleEntity.builder().build(), | |||
| .saveAll(asList(SampleEntity.builder().build(), SampleEntity.builder().build(), | |||
There was a problem hiding this comment.
Nit: We generally don't import Arrays statically to avoid clashes.
There was a problem hiding this comment.
Hmm, I only knew the rule that static imports are ok in tests. Will undo
There was a problem hiding this comment.
I reverted those changes.
mp911de
pushed a commit
that referenced
this pull request
Nov 25, 2020
…teAllById(Iterable<ID> ids). Original pull request: #554.
mp911de
added a commit
that referenced
this pull request
Nov 25, 2020
Use deleteAllById(…) from deleteAll(…). Simplify implementation in SimpleReactiveElasticsearchRepository. Original pull request: #554.
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge directly after DATACMNS-800