Skip to content

DATACOUCH-29 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

DATACOUCH-29 #6

wants to merge 3 commits into from

Conversation

dharrigan
Copy link
Contributor

Add Gradle (1.8) to Spring Data Couchbase.

-=david=-

David Harrigan and others added 3 commits September 27, 2013 09:22
Add Gradle (1.8) to Spring Data Couchbase.

-=david=-
@daschl
Copy link
Contributor

daschl commented Sep 30, 2013

Hi @dharrigan

thanks for your PR, but what is the reason you want to add gradle? the project is currently a maven project, I'm not sure I see the immediate benefit of it (other than having to duplicate build changes all the time).

Let me know, thanks :)

@dharrigan
Copy link
Contributor Author

Hi Michael,

I think the main reason is that if this is becoming an official Spring project, I believe it should adopt the trend in Spring that the majority of projects have now moved to Gradle as their official build system. I believe that in the long term this would need to be done anyway, so perhaps get it in sooner rather than later is nice :-)

Thank you again for this nice project. I'm actively looking at ways to contribute. I've hand written the Java <-> Couchbase code that uses your couchbase-client jar and Spring, so seeing this come is great - I can eventually remove a lot of boiler plate code :-) Esp when find* methods come by :-)

-=david=-

@daschl
Copy link
Contributor

daschl commented Sep 30, 2013

@olivergierke what do you think, should we move over to gradle completely? I basically don't care on the project, its just that I want to avoid duplicating work if possible. What's the long term strategy for the whole spring-data package?

@odrotbohm
Copy link
Member

So far, we're not planning to move the Spring Data Projects to Gradle anytime soon. This is mostly due to the fact that the IDE support for inter-project dependencies in the IDE (esp. Eclipse) is still underwhelming and there's no obvious benefits over the currently just working build.

@daschl
Copy link
Contributor

daschl commented Sep 30, 2013

@dharrigan then I think we should stick with a unified dependency management tool so we don't mix around too much.

Does that work for you wrt to olivers response?

@dharrigan
Copy link
Contributor Author

Hi,

Of course :-) I defer to the experts :-)

I would say that with gradle it's a simple matter of doing "gradlew eclipse" or "gradlew idea" to generate all the projects files and dependency links :-)

I do hope that Eclipse gets good Gradle support soon (I use IntelliJ and that seems to be making good progress).

-=david=-

@daschl
Copy link
Contributor

daschl commented Sep 30, 2013

@dharrigan I'm also using IntelliJ and I think we'll move to gradle on the official java client for the next major version as well. But we'll see.

Anyways, thanks for the contribution(s)! Greatly appreciated!

@daschl daschl closed this Sep 30, 2013
@dharrigan
Copy link
Contributor Author

You are most welcome. I'm keen to help out more if I can! :-)

bclozel added a commit that referenced this pull request Aug 19, 2015
Conditionalize reference doc/api doc links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants