DATACOUCH-626 - Handle reading into entity with only all-args constru… #272

mikereiche · 2020-10-13T23:47:28Z

…ctor; version primative type

The version arg - which is not in the document - will be passed
into the constructor as a null which will fail if it is a primitive
type. This change will pre-populated the converted object with
the version/cas, so that it is not null.

You have read the Spring Data contribution guidelines.
There is a ticket in the bug tracker for the project in our JIRA.
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

daschl

Looks good to me, with couple nits

...g/springframework/data/couchbase/repository/CouchbaseRepositoryKeyValueIntegrationTests.java

src/test/java/org/springframework/data/couchbase/domain/SubscriptionTokenRepository.java

src/test/java/org/springframework/data/couchbase/domain/SubscriptionToken.java

…ctor; version primative type. The version arg - which is not in the document - will be passed into the constructor as a null which will fail if it is a primitive type. This change will pre-populated the converted object with the version/cas, so that it is not null.

mikereiche requested a review from daschl October 13, 2020 23:47

daschl suggested changes Oct 14, 2020

View reviewed changes

mikereiche force-pushed the datacouch_626_handle_all_args_const_read branch from 4a8a6d6 to 239ce94 Compare October 14, 2020 21:49

mikereiche merged commit 1955cf4 into master Oct 14, 2020

mikereiche deleted the datacouch_626_handle_all_args_const_read branch October 16, 2020 21:34

spring-projects-issues mentioned this pull request Dec 31, 2020

all-arguments constructor incompatible with '@Version private long version' [DATACOUCH-626] #937

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DATACOUCH-626 - Handle reading into entity with only all-args constru… #272

DATACOUCH-626 - Handle reading into entity with only all-args constru… #272

mikereiche commented Oct 13, 2020

daschl left a comment

DATACOUCH-626 - Handle reading into entity with only all-args constru… #272

DATACOUCH-626 - Handle reading into entity with only all-args constru… #272

Conversation

mikereiche commented Oct 13, 2020

daschl left a comment

Choose a reason for hiding this comment