DATACOUCH-623 - Add replace() method to CouchbaseRepository for CAS u…

[mikereiche]

…sage.

• You have read the Spring Data contribution guidelines.
• There is a ticket in the bug tracker for the project in our JIRA.
• You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
• You submit test cases (unit or integration tests) that back your changes.
• You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

[mp911de]

Adding technology-specific methods violates somewhat the concept of handling technology-specific aspects inside the repository/template API. I left a comment on DATACOUCH-623. Especially entities annotated with @Version shouldn't require the user to call a different method for proper handling, instead, the requirement to issue a different store-specific replace call should be determined by the Spring Data code and not the caller.

[mikereiche]

Thanks Mark. I put the upsert() vs. replace() logic in the save().

[daschl]

@mikereiche after looking into this I agree with @mp911de's comment in https://jira.spring.io/browse/DATACOUCH-623?focusedCommentId=191380&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-191380 .. Let's not add to the repository, but rather in our internal code check if the version is present and if present and set use a replace operation and map to the corresponding exception.

[daschl]

I think that method can be DRY'ed up? only provided it once and reuse.. also maybe a name that also clarifies it must be present AND not 0 might be better

[mikereiche]

Done. I put it in a new Utils class.
I had thought of that, but SimpleReactiveCouchbaseRepository has a ReactiveCouchbaseOperations, while SimpleCouchbaseRepository has a CouchbaseOperations. But it doesn't actually need those - it just needs the mapping conext of the converter held by each *Operations - which is the same type.