DATACOUCH-605 - Support ScanConsistency in n1ql queries #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mikereiche
commented
Oct 2, 2020
mikereiche
commented
- You have read the Spring Data contribution guidelines.
- There is a ticket in the bug tracker for the project in our JIRA.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
daschl
suggested changes
Oct 2, 2020
src/main/java/org/springframework/data/couchbase/core/ReactiveInsertByIdOperationSupport.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/couchbase/core/ReactiveUpsertByIdOperationSupport.java
Show resolved
Hide resolved
| * | ||
| * @return queryScanConsistency | ||
| */ | ||
| public QueryScanConsistency getConsistency() { |
There was a problem hiding this comment.
do we need a public getter on this?
There was a problem hiding this comment.
It's used by ExecutableFindByQuerySupport.matching(Query) - if Query has scanConsistency set, it is taken from there instead of requiring a separate call to ExecutableFindByQuerySupport.consistentWith( scanConsistency ).
| * @param queryScanConsistency | ||
| * @return this | ||
| */ | ||
| public Query with(final QueryScanConsistency queryScanConsistency) { |
There was a problem hiding this comment.
shouldn't this be more like scanConsistency(..) ? we also name limit etc. explicitly.
There was a problem hiding this comment.
Ok - I changed it to scanConsistency(). But I was looking at with(Pageable) and with(Sort).
But that pattern breaks down for things like skip and limit which are just int.
mikereiche
force-pushed
the
datacouch_605_scanconsistency_option
branch
from
b32746c to
f246c3b
Compare
mikereiche
force-pushed
the
datacouch_605_scanconsistency_option
branch
from
f246c3b to
4862dcc
Compare
This was referenced Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.