DATACOUCH-608 - propagate expiry option and annotation to insert and … #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikereiche
force-pushed
the
datacouch_608_propagate_expiry_option_annotation
branch
from
ff06fb5 to
c846ec4
Compare
daschl
suggested changes
Sep 15, 2020
|
|
||
| @Override | ||
| public InsertByIdWithDurability<T> withExpiry(final Duration expiry) { | ||
| return new ExecutableInsertByIdSupport<>(template, domainType, collection, persistTo, replicateTo, |
There was a problem hiding this comment.
Assert.notNull(expiry,..) checking might make sense here
|
|
||
| @Override | ||
| public UpsertByIdWithDurability<T> withExpiry(final Duration expiry) { | ||
| Assert.notNull(persistTo, "PersistTo must not be null."); |
There was a problem hiding this comment.
these assertions are checking the wrong thing, copy/paste err?
There was a problem hiding this comment.
Yes. Replaced with correct check on expiry. Also changed initialization to use expiry of Duration.ofSeconds(0) instead of null for consistency.
| try { | ||
| User inserted = couchbaseTemplate.insertById(User.class).withExpiry(Duration.ofSeconds(1)).one(user); | ||
| assertEquals(user, inserted); | ||
| sleepSecs(2); |
There was a problem hiding this comment.
are these sleeps needed in those places? kv should not be eventually consistent but rather directly
There was a problem hiding this comment.
The sleeps are need to allow the document to expire.
mikereiche
force-pushed
the
datacouch_608_propagate_expiry_option_annotation
branch
from
c846ec4 to
bd0252a
Compare
daschl
approved these changes
Sep 16, 2020
mikereiche
deleted the
datacouch_608_propagate_expiry_option_annotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…upsert calls