Skip to content

Propagated CouchbaseCustomConverters bean into MappingConverter #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2024
Merged

Propagated CouchbaseCustomConverters bean into MappingConverter #1885

merged 2 commits into from
Jan 10, 2024

Conversation

bipoool
Copy link
Contributor

@bipoool bipoool commented Dec 26, 2023 •
edited
Loading

Propagated CouchbaseCustomConverters bean into MappingConverter.

Just a polishing fix to propagate CouchbaseCustomConversions directly to MappingCouchbaseConverter -> AbstractCouchbaseConverter , So that we won't have to set it explicitly. Fixes #1850 .

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@bipoool bipoool marked this pull request as draft December 26, 2023 17:06
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 26, 2023
@bipoool bipoool marked this pull request as ready for review December 26, 2023 18:37
@bipoool
Propagated CouchbaseCustomConverters bean into MappingConverter.
c26f094 
Just a polishing fix to propagate CouchbaseCustomConversions directly to MappingCouchbaseConverter -> AbstractCouchbaseConverter , So that we won't have to set it explicitly.
@bipoool bipoool force-pushed the fix/customConversionsBeanPropagation branch from 669fcb3 to c26f094 Compare December 30, 2023 13:41
@mikereiche mikereiche merged commit 6e17572 into spring-projects:main Jan 10, 2024
mikereiche pushed a commit that referenced this pull request Jan 18, 2024
@bipoool @mikereiche
Propagated CouchbaseCustomConverters bean into MappingConverter (#1885)
38212b4 
* Propagated CouchbaseCustomConverters bean into MappingConverter.

Just a polishing fix to propagate CouchbaseCustomConversions directly to MappingCouchbaseConverter -> AbstractCouchbaseConverter , So that we won't have to set it explicitly.

* Removed unnecessary constructor.
mikereiche pushed a commit that referenced this pull request Jan 18, 2024
@bipoool @mikereiche
Propagated CouchbaseCustomConverters bean into MappingConverter (#1885)
5eea30e 
* Propagated CouchbaseCustomConverters bean into MappingConverter.

Just a polishing fix to propagate CouchbaseCustomConversions directly to MappingCouchbaseConverter -> AbstractCouchbaseConverter , So that we won't have to set it explicitly.

* Removed unnecessary constructor.
mikereiche pushed a commit that referenced this pull request Jan 18, 2024
@bipoool @mikereiche
Propagated CouchbaseCustomConverters bean into MappingConverter (#1885)
82d1798 
* Propagated CouchbaseCustomConverters bean into MappingConverter.

Just a polishing fix to propagate CouchbaseCustomConversions directly to MappingCouchbaseConverter -> AbstractCouchbaseConverter , So that we won't have to set it explicitly.

* Removed unnecessary constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propagate CouchbaseCustomConverters bean into MappingConverter constructor
3 participants
@bipoool @spring-projects-issues @mikereiche