Skip to content

Bump Couchbase SDK to 3.4.0. #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

mikereiche
Copy link
Collaborator

Closes #1596.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@mikereiche mikereiche requested a review from daschl October 28, 2022 22:44
@mikereiche
Copy link
Collaborator Author

@programmatix
Ideally I'd use the insert() method of ReactiveAttemptTransactionContext, but I only have the CoreAttemptTransactionContext at this point and the constructor to create a ReactiveAttemptTransactionContext from a CoreAttemptTransactionContext is no public.
I've just cut-and-pasted the construction of the span, and passed that into the internal method. Note that the encoding is done with the spring-data-couchbase and note the transaction encode().

@mikereiche mikereiche merged commit 6117c18 into main Oct 31, 2022
@mikereiche mikereiche deleted the datacouch_1596_couchbase_sdk_to_3_4_0 branch January 24, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump 5.0.0 (main) couchbase sdk to 3.4.0
1 participant