Skip to content

Consider scope and collection from repository annotation in deletes #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Consider scope and collection from repository annotation in deletes #1466

wants to merge 13 commits into from

Conversation

mikereiche
Copy link
Collaborator

@mikereiche mikereiche commented Jun 17, 2022 •
edited
Loading

Closes #1441.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

mikereiche added 13 commits June 14, 2022 14:48
@mikereiche
Add n1ql.scope and n1ql.collection spel expressions for @query.
80689ae 
This adds n1ql.scope and n1ql.collection spel expressions for
@query so that n1ql.bucket doesn't need to be overloaded with
the collection name. This will make the bucket name available
in n1q.bucket.

This is a breaking change as queries that used n1ql.bucket to
get the collection name (especially in the case of pre-scope-
and-collection @queries that (a) referenced n1ql.bucket instead
of referencing other spel expressions that include the
bucket/collection name; and (b)  still worked after the
repository was moved from a bucket onto a collection by
virtue of n1ql.bucket having the value of the collection in
such instances.

Closes #1445.
@mikereiche
Consider scope and collection from repository annotations.
65f3b01 
The scope and collection from the repository annotation are associated with
the method call by CrudMethodMetadataProcessor. This will also need #1445 to
work.

Closes #1441.
@mikereiche
Merge branch 'datacouch_1445_add_n1ql_scope_and_collection_spel' of g…
a103000 
…ithub.com:spring-projects/spring-data-couchbase into datacouch_1441_consider_scope_and_collection_from_repository_annotation

Needed to test functionality.
@mikereiche
Ensure that repo methods consider the scope and collection annotation…
88cf759 
… of the repo class.

Closes #1441.
@mikereiche
Consider scope and collection from repository annotations.
7648cfa 
The scope and collection from the repository annotation are associated with
the method call by CrudMethodMetadataProcessor. This will also need #1445 to
work.

Closes #1441.
@mikereiche
Ensure that repo methods consider the scope and collection annotation…
9edb4b4 
… of the repo class.

Closes #1441.
@mikereiche
Merge branch 'datacouch_1441_consider_scope_and_collection_from_repos…
f7bc253 
…itory_annotation' of github.com:spring-projects/spring-data-couchbase into datacouch_1441_consider_scope_and_collection_from_repository_annotation
@mikereiche
Consider scope and collection from repository annotations.
82d75c8 
The scope and collection from the repository annotation are associated with
the method call by CrudMethodMetadataProcessor. This will also need #1445 to
work.

Closes #1441.
@mikereiche
Ensure that repo methods consider the scope and collection annotation…
9b4a3c8 
… of the repo class.

Closes #1441.
@mikereiche
Merge branch 'datacouch_1441_consider_scope_and_collection_from_repos…
46a92bf 
…itory_annotation' of github.com:spring-projects/spring-data-couchbase into datacouch_1441_consider_scope_and_collection_from_repository_annotation
@mikereiche
Consider scope and collection from repository annotations.
cb073e7 
The scope and collection from the repository annotation are associated with
the method call by CrudMethodMetadataProcessor. This will also need #1445 to
work.

Closes #1441.
@mikereiche
Ensure that repo methods consider the scope and collection annotation…
bf46b0b 
… of the repo class.

Closes #1441.
@mikereiche
Merge branch 'datacouch_1441_consider_scope_and_collection_from_repos…
9db7433 
…itory_annotation' of github.com:spring-projects/spring-data-couchbase into datacouch_1441_consider_scope_and_collection_from_repository_annotation
@mikereiche mikereiche closed this Jun 17, 2022
@mikereiche mikereiche deleted the datacouch_1441_consider_scope_and_collection_from_repository_annotation branch June 17, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scope and collection annotations on repository are not considered during execution.
1 participant
@mikereiche