Programmatix datacouch 1145 transaction support #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mikereiche
commented
May 27, 2022
mikereiche
commented
- You have read the Spring Data contribution guidelines.
- There is a ticket in the bug tracker for the project in our JIRA.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
The transactions logic exists in the Java SDK as of 3.3.0, with a slightly different API. This is the first effort at the port, which literally just compiles. It will not run as crucial code has been commented and todo-ed. There is work remaining to figure out how to complete the port, as some crucial parts (such as ctx.commit() and ctx.rollback()) have been intentionally removed.
Trying to transition to CallbackPreferring manager.
possible implementation of CallbackPreferringTransactionManager, combined with a simpler approach to ThreadLocal storage in ReactiveInsertByIdSupport. Test 'commitShouldPersistTxEntriesOfTxAnnotatedMethod' is now passing.
(Not yet working as CAS/version field in Person is not populated correctly.)
Tests may fail.
Don't think we need this, as we can pass around CoreTransactionAttemptContext instead, which gives access to a lot of internals.
Would prefer not to C&P a huge class out of the transaction internals, and don't think we need it.
To reduce & simplify the amount of code to look at. Some don't seem to be used in any branch, some just aren't used in this branch.
As per offline discussion, CallbackPreferringPlatformTransactionManager is perhaps the optimal solution.
…onAttemptContext. Removing unused code.
Standardising on ReactiveCouchbaseResourceHolder rather than holding CoreTransactionAttemptContext too
Can't recall why I added this, and tests pass without it
By calling CoreTransactionAttemptContext.operationFailed, it ensures that internal state is set. So even if the user catches the exception, the transaction still behaves as it should.
I missed this when adding TransactionalSupport.verifyNotInTransaction here.
…om/programmatix/spring-data-couchbase into programmatix-datacouch_1145_transaction_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.