DATACOUCH-16 - Allow View customization through @View annotations. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An initial first attempt at allowing for basic View customization using the @view annotation. For now, it does not support "dynamic" finders, such as findByUsername, but I'm sure it will come shortly aftewards. Also added in hamcrest library to gradually transistion deprecated JUnit methods to a better assertion library :-) -=david=-
|
@olivergierke ping for a quick review - thanks! I like it. |
|
Merged! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial first attempt at allowing for basic View customization using the
@view annotation.
For now, it does not support "dynamic" finders, such as findByUsername, but
I'm sure it will come shortly aftewards.
Also added in hamcrest library to gradually transistion deprecated JUnit
methods to a better assertion library :-)
This is an updated PR that includes feedback from Oliver. It uses a ThreadLocal to store the View which is later retreived in the SimpleCouchbaseRepository. This is a similar approach as how LockModeRepositoryPostProcessor is used in Spring Data JPA.
I welcome feedback! :-)
-=david=-