Allow caching null objects. #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #939.
dnault
approved these changes
Jan 17, 2022
| /** | ||
| * This is a standalone class (vs. inner) to allow Serialization of all fields to work. | ||
| * If it was an inner class of CouchbaseCacheIntegrationTests, then it would have a | ||
| * this$0 field = CouchbaseCacheIntegrationTests and would not serialize. |
There was a problem hiding this comment.
If CacheUser were a static nested class, would it it still need to be in a separate file?
https://docs.oracle.com/javase/tutorial/java/javaOO/nested.html
dnault
approved these changes
Jan 17, 2022
| * @author Michael Reiche | ||
| */ | ||
| @IgnoreWhen(clusterTypes = ClusterType.MOCKED) | ||
| class CouchbaseCacheIntegrationTests extends JavaIntegrationTests { |
There was a problem hiding this comment.
These tests are good. Are they related to the "Allow caching null objects" change?
Should we have a test that caches and retrieves a null value?
There was a problem hiding this comment.
cacheHitMiss() tests a cache hit on a stored null.
It also tests a cache-miss - which is the same for a null as a non-null.
The other tests have cache-hits on non-null (the normal case).
mikereiche
added a commit
that referenced
this pull request
Feb 4, 2022
Closes #939. Co-authored-by: mikereiche <[email protected]>
mikereiche
added a commit
that referenced
this pull request
Feb 8, 2022
Closes #939. Co-authored-by: mikereiche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use toStoreValue(value) to substitute null objects with NullValue.INSTANCE when putting. fromStoreValue(value) does the opposite when getting.
Closes #939.