Add override of toN1qlRemoveString() to StringQuery. #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikereiche
force-pushed
the
datacouch_1131_implement_string_query_ton1qlremovestring
branch
from
94dd216 to
f1fb77a
Compare
daschl
suggested changes
May 4, 2021
| @@ -323,18 +323,24 @@ public String toN1qlRemoveString(ReactiveCouchbaseTemplate template, String coll | |||
| * @return QueryOptions | |||
| */ | |||
| public QueryOptions buildQueryOptions(QueryScanConsistency scanConsistency) { | |||
| final QueryOptions options = QueryOptions.queryOptions(); | |||
| QueryOptions options = QueryOptions.queryOptions(); | |||
| if (options == null) { // add/override what we got from PseudoArgs | |||
There was a problem hiding this comment.
that line does not make sense, since the line above you always set it to non-null?
There was a problem hiding this comment.
Right. The code is copied from the Collections branch to reduce the future merge. And in that code 'options' is an argument and needs to be checked.
| @@ -73,4 +73,16 @@ public String toN1qlSelectString(ReactiveCouchbaseTemplate template, String coll | |||
| appendSkipAndLimit(statement); | |||
| return statement.toString(); | |||
| } | |||
|
|
|||
| @Override | |||
mikereiche
force-pushed
the
datacouch_1131_implement_string_query_ton1qlremovestring
branch
from
f1fb77a to
e9e8411
Compare
mikereiche
added a commit
that referenced
this pull request
Aug 9, 2021
Closes #1131. Original pull request: #1135. Co-authored-by: mikereiche <[email protected]>
mikereiche
deleted the
datacouch_1131_implement_string_query_ton1qlremovestring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1131.