Skip to content

Fix N1QLExpression keys. #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 31, 2021
Merged

Fix N1QLExpression keys. #1115

merged 7 commits into from
Mar 31, 2021

Conversation

mikereiche
Copy link
Collaborator

Fix formatting of N1QLExpression keys.

Closes #1064.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

quaff and others added 6 commits March 22, 2021 11:25
@quaff
Fix indent (#1094)
3787fcc
@mikereiche
Update versions to correct values.
2554e61 
Closes #1105.

Co-authored-by: mikereiche <[email protected]>
@mikereiche
Use queryScanConsistency on reactive deleteAll().
ee04012 
It was present on non-Reactive, but missing from reactive.

Closes #1096.
Original pull request: #1108.

Co-authored-by: mikereiche <[email protected]>
@mikereiche
Add QueryCriteria arrayContaining.
322c4f6 
Add QueryCriteria arrayContaining which maps to n1ql array_containing.

Closes #1073.
Original pull request: #1109.

Co-authored-by: mikereiche <[email protected]>
@mikereiche
Support enum arguments on repository queries.
ef9c5f4 
Support enum in AbstractCouchbaseConverter.convertForWriteIfNeeded()
and also call that from
MappingCouchbaseConverter.getPotentiallyConvertedSimpleWrite()

Closes #1069.
Original pull request: #1112.

Co-authored-by: mikereiche <[email protected]>
@mikereiche
Fix N1QLExpression keys.
3860ac3 
Closes #1064.
@mikereiche mikereiche requested a review from daschl March 30, 2021 21:19
@daschl
Copy link
Contributor

daschl commented Mar 31, 2021

@mikereiche that change looks good, but I think you need to re-do / rebase it on top of master since it has more of the commit history in here.

@mikereiche
Merge branch 'master' of github.com:spring-projects/spring-data-couch…
9113cdd 
…base into datacouch_1064_fix_n1ql_expression_keys_2
@mikereiche mikereiche merged commit 2e8d655 into master Mar 31, 2021
@mikereiche mikereiche deleted the datacouch_1064_fix_n1ql_expression_keys_2 branch August 11, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschl daschl Awaiting requested review from daschl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

N1QLExpression#keys is broken
3 participants
@mikereiche @daschl @quaff