Skip to content

GH-1066/GH-1072 - Support use of META() in N1QLQueryCreator and changed QueryCriteria to use N1QLExpression as key #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

mmonti
Copy link

@mmonti mmonti commented Feb 5, 2021

This commit fixes the generated query by N1QLQueryCreator when the criteria includes an id or a version property, adding a META($bucket) function

It also removes the need of maybeBacktics() in QueryCriteria defining N1QLExpression as key instead of String.
Public methods where(), and() and or() with String key delegate to the same with N1QLExpression as argument.

Related tickets:

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

…iteria includes an id or a version property, using META($bucket).

It also solves removes the need of maybeBacktics() in QueryCriteria using N1QLExpression as key

Related tickets #1072, #1066
- #1072
- #1066
…r() but receiving a String key.

Related tickets:
- #1072
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 5, 2021
@mmonti mmonti marked this pull request as ready for review February 9, 2021 16:53
mikereiche added a commit that referenced this pull request Feb 17, 2021
This is a merge of mmonti's changeset into master.  The changeset was made
on top of 4.1.x instead of master so it has a little catching up to do.

Merge branch 'gh-1066-n1qlexpression-as-querycriteria-key' of github.com:mmonti/spring-data-couchbase into datacouch_1066_1072_mmonti_n1ql_query_creator_expression

Original pull request #1076
@mikereiche mikereiche linked an issue Feb 22, 2021 that may be closed by this pull request
@mikereiche mikereiche closed this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findById...AndXXX method derived query generates wrong statement
3 participants