-
Notifications
You must be signed in to change notification settings - Fork 192
#n1ql.bucket returns the collection in v5 #1799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like the second constructor has the correct call at line 197, but the first constructor has the incorrect call at line 169. That plus StringN1qlQueryCreatorTests.spelTests would need to be changed. I'm trying to figure out if it was left like that. intentionally or if by accident/error. |
OK, if you think it should be changed, I'm ready to create a PR ) |
Yes. Submit the PR and I'll approve it. It will change the behavior mid-version, but it's a bug-fix Be sure to also fix the test case I indicated. I'm not sure if you're already running the integration tests against a real cb server, but to do that edit src/test/resources/integration.properties to point to a real server before running mvn integration-test. mine looks like this -
|
…based queries. Closes spring-projects#1799
Based on the answers from #1536 and #1445 it seems that the
#n1ql.bucket
should always return bucket name starting from version 5, but still even in the latest versions, it returns the collection name.I'm asking about this line https://github.com/spring-projects/spring-data-couchbase/blob/f41d4b94e07923fec2f75ce71c51ea7f376112d0/src/main/java/org/springframework/data/couchbase/repository/query/StringBasedN1qlQueryParser.java#L169C30-L169C30
Should this be fixed? Or was the change postponed for the next major version?
The text was updated successfully, but these errors were encountered: