Skip to content

Automatically set QueryOptions readonly #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
micopiira opened this issue Apr 27, 2023 · 1 comment · Fixed by #1730
Closed

Automatically set QueryOptions readonly #1724

micopiira opened this issue Apr 27, 2023 · 1 comment · Fixed by #1730
Labels
status: feedback-provided Feedback has been provided

Comments

@micopiira
Copy link
Contributor

When querying through (Reactive)CouchbaseTemplate, should query/count methods like all(), one(), count(), etc. automatically set the QueryOptions readonly to true?

In addition to providing some security in that you are not accidentally modifying data, setting this flag to true
also helps the client to more proactively retry and re-dispatch a query since then it can be sure it is idempotent.
As a result, if your query is readonly then it is a good idea to set this flag.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 27, 2023
@mikereiche
Copy link
Collaborator

They could. Submit a PR for it and I'll approve it.

@mikereiche mikereiche added status: feedback-provided Feedback has been provided and removed status: waiting-for-triage An issue we've not yet triaged labels May 3, 2023
@micopiira micopiira mentioned this issue May 8, 2023
Merged
mikereiche pushed a commit that referenced this issue May 9, 2023
@micopiira
Automatically set readonly query option for read only queries (#1730)
9b8d855 
Closes #1724
mikereiche pushed a commit that referenced this issue Aug 9, 2023
@micopiira @mikereiche
Automatically set readonly query option for read only queries (#1730)
fafbffa 
Closes #1724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: feedback-provided Feedback has been provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically set readonly query option for read only queries
3 participants
@micopiira @spring-projects-issues @mikereiche