Questions about durability with scopes and collections

[jorgerod]

Hello

I've been looking at the added feature of scopes and collections and I've seen an issue that I don't know if it's correct.

• This methods of interfaces {Operation}ByIdWithDurability return {Operation}ByIdInScope:

spring-data-couchbase/src/main/java/org/springframework/data/couchbase/core/ExecutableUpsertByIdOperation.java

Lines 116 to 122 in 32f6a05

	interface UpsertByIdWithDurability<T> extends UpsertByIdInScope<T>, WithDurability<T> {
	@Override
	UpsertByIdInScope<T> withDurability(DurabilityLevel durabilityLevel);
	@Override
	UpsertByIdInScope<T> withDurability(PersistTo persistTo, ReplicateTo replicateTo);

spring-data-couchbase/src/main/java/org/springframework/data/couchbase/core/ExecutableReplaceByIdOperation.java

Lines 116 to 122 in 32f6a05

	interface ReplaceByIdWithDurability<T> extends ReplaceByIdInScope<T>, WithDurability<T> {
	@Override
	ReplaceByIdInScope<T> withDurability(DurabilityLevel durabilityLevel);
	@Override
	ReplaceByIdInScope<T> withDurability(PersistTo persistTo, ReplicateTo replicateTo);
	}

• and this methods return {Operation}ByInCollection:

spring-data-couchbase/src/main/java/org/springframework/data/couchbase/core/ExecutableInsertByIdOperation.java

Lines 117 to 123 in 32f6a05

	interface InsertByIdWithDurability<T> extends InsertByIdInScope<T>, WithDurability<T> {
	@Override
	InsertByIdInCollection<T> withDurability(DurabilityLevel durabilityLevel);
	@Override
	InsertByIdInCollection<T> withDurability(PersistTo persistTo, ReplicateTo replicateTo);

spring-data-couchbase/src/main/java/org/springframework/data/couchbase/core/ReactiveUpsertByIdOperation.java

Lines 119 to 125 in 32f6a05

	interface UpsertByIdWithDurability<T> extends UpsertByIdInScope<T>, WithDurability<T> {
	@Override
	UpsertByIdInCollection<T> withDurability(DurabilityLevel durabilityLevel);
	@Override
	UpsertByIdInCollection<T> withDurability(PersistTo persistTo, ReplicateTo replicateTo);

spring-data-couchbase/src/main/java/org/springframework/data/couchbase/core/ReactiveReplaceByIdOperation.java

Lines 117 to 123 in 32f6a05

	interface ReplaceByIdWithDurability<T> extends ReplaceByIdInScope<T>, WithDurability<T> {
	ReplaceByIdInCollection<T> withDurability(DurabilityLevel durabilityLevel);
	ReplaceByIdInCollection<T> withDurability(PersistTo persistTo, ReplicateTo replicateTo);
	}

spring-data-couchbase/src/main/java/org/springframework/data/couchbase/core/ReactiveInsertByIdOperation.java

Lines 113 to 119 in 32f6a05

	interface InsertByIdWithDurability<T> extends InsertByIdInScope<T>, WithDurability<T> {
	@Override
	InsertByIdInCollection<T> withDurability(DurabilityLevel durabilityLevel);
	@Override
	InsertByIdInCollection<T> withDurability(PersistTo persistTo, ReplicateTo replicateTo);

spring-data-couchbase/src/main/java/org/springframework/data/couchbase/core/ReactiveRemoveByIdOperation.java

Lines 113 to 119 in 32f6a05

	interface RemoveByIdWithDurability extends RemoveByIdInScope, WithDurability<RemoveResult> {
	@Override
	RemoveByIdInCollection withDurability(DurabilityLevel durabilityLevel);
	@Override
	RemoveByIdInCollection withDurability(PersistTo persistTo, ReplicateTo replicateTo);

spring-data-couchbase/src/main/java/org/springframework/data/couchbase/core/ExecutableRemoveByIdOperation.java

Lines 114 to 120 in 32f6a05

	interface RemoveByIdWithDurability extends RemoveByIdInScope, WithDurability<RemoveResult> {
	@Override
	RemoveByIdInCollection withDurability(DurabilityLevel durabilityLevel);
	@Override
	RemoveByIdInCollection withDurability(PersistTo persistTo, ReplicateTo replicateTo);

I think the correct thing to do would be for those methods to return {Operation}ByInScope because then we could do .withDurability().withScope("").withCollection("")

How do you see it?