AbstractTemplateSupport.decodeEntityBase() saves version property twice (?)

[mikereiche]

It puts it in the new document, then reads that document into readEntity, then sets it again in readEntity.

public <T> T decodeEntityBase(String id, String source, long cas, Class<T> entityClass,
															TransactionResultHolder txResultHolder) {

	final CouchbaseDocument converted = new CouchbaseDocument(id);
	converted.setId(id);
	CouchbasePersistentEntity<?> persistentEntity = mappingContext.getRequiredPersistentEntity(entityClass);
	if (cas != 0 && persistentEntity.getVersionProperty() != null) {
		converted.put(persistentEntity.getVersionProperty().getName(), cas);
	}

	T readEntity = converter.read(entityClass, (CouchbaseDocument) translationService.decode(source, converted));
	final ConvertingPropertyAccessor<T> accessor = getPropertyAccessor(readEntity);

	if (persistentEntity.getVersionProperty() != null) {
		accessor.setProperty(persistentEntity.getVersionProperty(), cas);
	}
	if (persistentEntity.transactionResultProperty() != null) {
		accessor.setProperty(persistentEntity.transactionResultProperty(), System.identityHashCode(txResultHolder));
	}
	N1qlJoinResolver.handleProperties(persistentEntity, accessor, getReactiveTemplate(), id);
	return accessor.getBean();
}

[mikereiche]

Be careful about any 'fixing' here.
The first time it sets it in the 'converted' CouchbaseDocument, the second time it sets it in the resulting entity object.

Refer to #937

[mikereiche]

It's set the first time in case the entity constructor has a "long version" argument. Null is not valid for a "long" argument and an exception will be thrown. This can be avoided by making the argument "Long version"