DATACOUCH-532 - Use parameters in queries instead of literals.

This will allow query plans to be reused for different parameters.

Author: mikereiche

src/main/java/org/springframework/data/couchbase/core/query/Query.java

@@ -248,7 +248,7 @@ public String toN1qlString(ReactiveCouchbaseTemplate template, Class domainClass
 		final StringBuilder statement = new StringBuilder();
 		appendString(statement, n1ql.selectEntity); // select ...
 		appendWhereString(statement, n1ql.filter); // typeKey = typeValue
-		appendWhere(statement, null); // criteria on this Query
+		appendWhere(statement, new int[] { 0 }); // criteria on this Query
 		appendSort(statement);
 		appendSkipAndLimit(statement);
 		return statement.toString();

src/test/java/org/springframework/data/couchbase/repository/CouchbaseRepositoryQueryIntegrationTests.java

@@ -83,6 +83,29 @@ void shouldSaveAndFindAll() {
 		}
 	}
 
+	// "1\" or name=name or name=\"1")
+	@Test
+	void findByInjection() {
+		Airport vie = null;
+		Airport xxx = null;
+		try {
+			vie = new Airport("airports::vie", "vie", "loww");
+			airportRepository.save(vie);
+			xxx = new Airport("airports::xxx", "xxx", "xxxx");
+			airportRepository.save(xxx);
+			sleep(1000);
+			List<Airport> airports;
+			airports = airportRepository.findAllByIata("1\" or iata=iata or iata=\"1");
+			assertEquals(0, airports.size());
+			airports = airportRepository.findAllByIata("vie");
+			assertEquals(1, airports.size());
+		} finally {
+			airportRepository.delete(vie);
+			airportRepository.delete(xxx);
+		}
+
+	}
+
 	@Test
 	void findBySimpleProperty() {
 		Airport vie = null;