Skip to content

Allow dynamic limiting of repository query results #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue May 12, 2023 · 0 comments
Closed

Allow dynamic limiting of repository query results #2827

mp911de opened this issue May 12, 2023 · 0 comments
Assignees
@christophstrobl
Labels
type: enhancement A general enhancement
Milestone
3.2 M1 (2023.1.0)

Comments

@mp911de
Copy link
Member

mp911de commented May 12, 2023

We can use query methods to express static limits for derived queries through findTop10By… or dynamic limits via PageRequest.

When using ScrollPosition, we do not have a good way to define how many results should be produced by the query method as PageRequest cannot be used with ScrollPosition.
@mp911de mp911de added status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement labels May 12, 2023
@christophstrobl christophstrobl self-assigned this May 26, 2023
@christophstrobl christophstrobl linked a pull request May 31, 2023 that will close this issue
Introduce Limit type #2836
Closed
@christophstrobl christophstrobl mentioned this issue May 31, 2023
Closed
@mp911de mp911de closed this as completed in a5408a4 Jul 5, 2023
mp911de added a commit that referenced this issue Jul 5, 2023
@mp911de
Polishing.
15bb8aa 
Refine documentation. Introduce isLimited method to mirror isPresent/isSorted semantics. Introduce Pageable.toLimit() method to deduplicate code.

See #2827
Original pull request: #2836
@mp911de mp911de added this to the 3.2 M1 (2023.1.0) milestone Jul 5, 2023
@mp911de mp911de removed the status: pending-design-work Needs design work before any code can be developed label Jul 5, 2023
@christophstrobl christophstrobl mentioned this issue Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.2 M1 (2023.1.0)
Development

Successfully merging a pull request may close this issue.

Introduce Limit type spring-projects/spring-data-commons
2 participants
@mp911de @christophstrobl