Refactor and polish with Java 8 idioms #9781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
I've separated each refactor in different commits so the review can be focused on that particular improvement. I can squash them all if you prefer. |
ghost
closed this
ghost
reopened this
|
@philwebb @wilkinsona if you think that this PR could be considered at some point I can keep this branch up to date. If you want to reduce the scope of it or just discard it altogether please let me know. |
philwebb
changed the title
philwebb
added
type: enhancement
philwebb
pushed a commit
that referenced
this pull request
Jul 25, 2017
Where possible, explicit generic declarations to use the Java 8 diamond operator. See gh-9781
philwebb
pushed a commit
that referenced
this pull request
Jul 25, 2017
Replace existing `Collections.sort(...)` calls with `.sort(...)` directly on the collection instance. See gh-9781
philwebb
pushed a commit
that referenced
this pull request
Jul 25, 2017
Use multi-catch for exceptions whenever possible. See gh-9781
philwebb
pushed a commit
that referenced
this pull request
Jul 25, 2017
Update existing try/finally/close blocks to use "try with resources" See gh-9781
philwebb
pushed a commit
that referenced
this pull request
Jul 25, 2017
Replace anonymous inner classes with lambda declarations (when possible using method references). See gh-9781
philwebb
pushed a commit
that referenced
this pull request
Jul 25, 2017
philwebb
added a commit
that referenced
this pull request
Jul 25, 2017
…-idioms * pr/9781: Simplify comparator implementation Use lambdas when possible Replace try with try-with-resources Collapse catch clauses Replace Collections.sort() with direct sort call Replace explicit generics with diamond operator
|
Thanks very much for the PR. This has been merged to master with some changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.