Polish usage of '@ConditionalOnWebApplication' for consistency #45880
+85
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanming Zhou <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
changed the title
@ConditionalOnWebApplication for consistency
|
It's unfortunately hard to come up with a general rules for these that we can enforce. In some cases (like this one), I like the proposed change. In others, I prefer the extra context of the enclosing class (e.g. We should probably just deal with most of these as we find them. I was going to close this issue and suggest we do that, but I do like the update. I think we might just leave this one for a little while until the restructure work lands because we don't want to cause more rebase pain. Thanks for the PR @quaff. |
philwebb
added
type: task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.