Skip to content

Add OtlpGrpcSpanExporterBuilderCustomizer and OtlpHttpSpanExporterBuilderCustomizer customizers #44900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add OtlpGrpcSpanExporterBuilderCustomizer and OtlpHttpSpanExporterBuilderCustomizer customizers #44900

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Mar 25, 2025

See #44645

Also helps with that #36248 (comment)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 25, 2025
@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 26, 2025
@mhalbritter mhalbritter added this to the 3.5.x milestone Mar 26, 2025
@mhalbritter
Copy link
Contributor

Thanks @nosan. I think that's a good idea.

@mhalbritter mhalbritter mentioned this pull request Mar 26, 2025
Closed
@mhalbritter mhalbritter mentioned this pull request Mar 26, 2025
Open
@nosan
Copy link
Contributor Author

nosan commented Mar 26, 2025

@mhalbritter
I think it would be nice to merge #44789 before this one. That way, you would avoid any merge conflicts when merging 3.4.x -> main later. Once #44789 gets merged, I will rebase this one. WDYT?

@mhalbritter
Copy link
Contributor

Sure. #44789 is merged.

@nosan
Introduce OTLP span exporter builder customizers
d8583e3 
This commit introduces customizers for both
OtlpHttpSpanExporterBuilder and OtlpGrpcSpanExporterBuilder.

Signed-off-by: Dmytro Nosan <[email protected]>
@nosan
Copy link
Contributor Author

nosan commented Mar 26, 2025

Thanks, @mhalbritter.
I've rebased this one.

@mhalbritter mhalbritter changed the title Introduce OtlpGrpcSpanExporterBuilderCustomizer and OtlpHttpSpanExporterBuilderCustomizer customizers Add OtlpGrpcSpanExporterBuilderCustomizer and OtlpHttpSpanExporterBuilderCustomizer customizers Mar 26, 2025
@mhalbritter mhalbritter self-assigned this Mar 26, 2025
mhalbritter pushed a commit that referenced this pull request Mar 26, 2025
@nosan @mhalbritter
Add OTLP span exporter builder customizers
19004e0 
This commit adds customizers for both OtlpHttpSpanExporterBuilder
and OtlpGrpcSpanExporterBuilder.

See gh-44900

Signed-off-by: Dmytro Nosan <[email protected]>
mhalbritter added a commit that referenced this pull request Mar 26, 2025
@mhalbritter
Polish "Add OTLP span exporter builder customizers"
f36d9a9 
See gh-44900
@mhalbritter
Copy link
Contributor

Thanks @nosan !

@mhalbritter mhalbritter modified the milestones: 3.5.x, 3.5.0-RC1 Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhalbritter mhalbritter mhalbritter left review comments

Assignees

@mhalbritter mhalbritter

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.0-RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@nosan @mhalbritter @spring-projects-issues