-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Add Graylog Extended Log Format (GELF) for structured logging #42158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
slissner
wants to merge
1
commit into
spring-projects:main
from
slissner:feature/structured-logging-graylog-gelf
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
162 changes: 162 additions & 0 deletions
162
...g/springframework/boot/logging/log4j2/GraylogExtendedLogFormatStructuredLogFormatter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,162 @@ | ||
/* | ||
* Copyright 2012-2024 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.logging.log4j2; | ||
|
||
import java.math.BigDecimal; | ||
import java.util.Objects; | ||
import java.util.Set; | ||
import java.util.function.Function; | ||
import java.util.regex.Pattern; | ||
|
||
import org.apache.logging.log4j.Level; | ||
import org.apache.logging.log4j.core.LogEvent; | ||
import org.apache.logging.log4j.core.impl.ThrowableProxy; | ||
import org.apache.logging.log4j.core.net.Severity; | ||
import org.apache.logging.log4j.core.time.Instant; | ||
import org.apache.logging.log4j.message.Message; | ||
import org.apache.logging.log4j.util.ReadOnlyStringMap; | ||
|
||
import org.springframework.boot.json.JsonWriter; | ||
import org.springframework.boot.logging.structured.CommonStructuredLogFormat; | ||
import org.springframework.boot.logging.structured.GraylogExtendedLogFormatService; | ||
import org.springframework.boot.logging.structured.JsonWriterStructuredLogFormatter; | ||
import org.springframework.boot.logging.structured.StructuredLogFormatter; | ||
import org.springframework.core.env.Environment; | ||
import org.springframework.util.Assert; | ||
import org.springframework.util.ObjectUtils; | ||
|
||
/** | ||
* Log4j2 {@link StructuredLogFormatter} for | ||
* {@link CommonStructuredLogFormat#GRAYLOG_EXTENDED_LOG_FORMAT}. Supports GELF version | ||
* 1.1. | ||
* | ||
* @author Samuel Lissner | ||
*/ | ||
class GraylogExtendedLogFormatStructuredLogFormatter extends JsonWriterStructuredLogFormatter<LogEvent> { | ||
|
||
/** | ||
* Allowed characters in field names are any word character (letter, number, | ||
* underscore), dashes and dots. | ||
*/ | ||
private static final Pattern FIELD_NAME_VALID_PATTERN = Pattern.compile("^[\\w\\.\\-]*$"); | ||
|
||
/** | ||
* Every field been sent and prefixed with an underscore "_" will be treated as an | ||
* additional field. | ||
*/ | ||
private static final String ADDITIONAL_FIELD_PREFIX = "_"; | ||
|
||
/** | ||
* Libraries SHOULD not allow to send id as additional field ("_id"). Graylog server | ||
* nodes omit this field automatically. | ||
*/ | ||
private static final Set<String> ADDITIONAL_FIELD_ILLEGAL_KEYS = Set.of("_id"); | ||
|
||
/** | ||
* Default format to be used for the `full_message` property when there is a throwable | ||
* present in the log event. | ||
*/ | ||
private static final String DEFAULT_FULL_MESSAGE_WITH_THROWABLE_FORMAT = "%s%n%n%s"; | ||
|
||
GraylogExtendedLogFormatStructuredLogFormatter(Environment environment) { | ||
super((members) -> jsonMembers(environment, members)); | ||
} | ||
|
||
private static void jsonMembers(Environment environment, JsonWriter.Members<LogEvent> members) { | ||
members.add("version", "1.1"); | ||
|
||
mhalbritter marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// note: a blank message will lead to a Graylog error as of Graylog v6.0.x. We are | ||
// ignoring this here. | ||
members.add("short_message", LogEvent::getMessage).as(Message::getFormattedMessage); | ||
|
||
members.add("timestamp", LogEvent::getInstant) | ||
.as(GraylogExtendedLogFormatStructuredLogFormatter::formatTimeStamp); | ||
members.add("level", GraylogExtendedLogFormatStructuredLogFormatter::convertLevel); | ||
members.add("_level_name", LogEvent::getLevel).as(Level::name); | ||
|
||
members.add("_process_pid", environment.getProperty("spring.application.pid", Long.class)) | ||
.when(Objects::nonNull); | ||
members.add("_process_thread_name", LogEvent::getThreadName); | ||
|
||
GraylogExtendedLogFormatService.get(environment).jsonMembers(members); | ||
|
||
members.add("_log_logger", LogEvent::getLoggerName); | ||
|
||
members.from(LogEvent::getContextData) | ||
.whenNot(ReadOnlyStringMap::isEmpty) | ||
.usingPairs((contextData, pairs) -> contextData | ||
.forEach((key, value) -> pairs.accept(makeAdditionalFieldName(key), value))); | ||
|
||
members.add().whenNotNull(LogEvent::getThrownProxy).usingMembers((eventMembers) -> { | ||
final Function<LogEvent, ThrowableProxy> throwableProxyGetter = LogEvent::getThrownProxy; | ||
mhalbritter marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
eventMembers.add("full_message", | ||
GraylogExtendedLogFormatStructuredLogFormatter::formatFullMessageWithThrowable); | ||
eventMembers.add("_error_type", throwableProxyGetter.andThen(ThrowableProxy::getThrowable)) | ||
.whenNotNull() | ||
.as(ObjectUtils::nullSafeClassName); | ||
eventMembers.add("_error_stack_trace", | ||
throwableProxyGetter.andThen(ThrowableProxy::getExtendedStackTraceAsString)); | ||
eventMembers.add("_error_message", throwableProxyGetter.andThen(ThrowableProxy::getMessage)); | ||
}); | ||
} | ||
|
||
/** | ||
* GELF requires "seconds since UNIX epoch with optional <b>decimal places for | ||
* milliseconds</b>". To comply with this requirement, we format a POSIX timestamp | ||
* with millisecond precision as e.g. "1725459730385" -> "1725459730.385" | ||
* @param timeStamp the timestamp of the log message. Note it is not the standard Java | ||
* `Instant` type but {@link org.apache.logging.log4j.core.time} | ||
* @return the timestamp formatted as string with millisecond precision | ||
*/ | ||
private static double formatTimeStamp(final Instant timeStamp) { | ||
return new BigDecimal(timeStamp.getEpochMillisecond()).movePointLeft(3).doubleValue(); | ||
mhalbritter marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
/** | ||
* Converts the log4j2 event level to the Syslog event level code. | ||
* @param event the log event | ||
* @return an integer representing the syslog log level code | ||
* @see Severity class from Log4j2 which contains the conversion logic | ||
*/ | ||
private static int convertLevel(final LogEvent event) { | ||
return Severity.getSeverity(event.getLevel()).getCode(); | ||
} | ||
|
||
private static String formatFullMessageWithThrowable(final LogEvent event) { | ||
return String.format(DEFAULT_FULL_MESSAGE_WITH_THROWABLE_FORMAT, event.getMessage().getFormattedMessage(), | ||
event.getThrownProxy().getExtendedStackTraceAsString()); | ||
} | ||
|
||
private static String makeAdditionalFieldName(String fieldName) { | ||
Assert.notNull(fieldName, "fieldName must not be null"); | ||
Assert.isTrue(FIELD_NAME_VALID_PATTERN.matcher(fieldName).matches(), | ||
() -> String.format("fieldName must be a valid according to GELF standard. [fieldName=%s]", fieldName)); | ||
Assert.isTrue(!ADDITIONAL_FIELD_ILLEGAL_KEYS.contains(fieldName), () -> String.format( | ||
"fieldName must not be an illegal additional field key according to GELF standard. [fieldName=%s]", | ||
fieldName)); | ||
|
||
if (fieldName.startsWith(ADDITIONAL_FIELD_PREFIX)) { | ||
// No need to prepend the `ADDITIONAL_FIELD_PREFIX` in case the caller already | ||
// has prepended the prefix. | ||
return fieldName; | ||
} | ||
|
||
return ADDITIONAL_FIELD_PREFIX + fieldName; | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
160 changes: 160 additions & 0 deletions
160
.../springframework/boot/logging/logback/GraylogExtendedLogFormatStructuredLogFormatter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,160 @@ | ||
/* | ||
* Copyright 2012-2024 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.logging.logback; | ||
|
||
import java.math.BigDecimal; | ||
import java.util.Map; | ||
import java.util.Objects; | ||
import java.util.Set; | ||
import java.util.function.Function; | ||
import java.util.regex.Pattern; | ||
import java.util.stream.Collectors; | ||
|
||
import ch.qos.logback.classic.pattern.ThrowableProxyConverter; | ||
import ch.qos.logback.classic.spi.ILoggingEvent; | ||
import ch.qos.logback.classic.spi.IThrowableProxy; | ||
import ch.qos.logback.classic.util.LevelToSyslogSeverity; | ||
import org.slf4j.event.KeyValuePair; | ||
|
||
import org.springframework.boot.json.JsonWriter; | ||
import org.springframework.boot.json.JsonWriter.PairExtractor; | ||
import org.springframework.boot.logging.structured.CommonStructuredLogFormat; | ||
import org.springframework.boot.logging.structured.GraylogExtendedLogFormatService; | ||
import org.springframework.boot.logging.structured.JsonWriterStructuredLogFormatter; | ||
import org.springframework.boot.logging.structured.StructuredLogFormatter; | ||
import org.springframework.core.env.Environment; | ||
import org.springframework.util.Assert; | ||
|
||
/** | ||
* Logback {@link StructuredLogFormatter} for | ||
* {@link CommonStructuredLogFormat#GRAYLOG_EXTENDED_LOG_FORMAT}. Supports GELF version | ||
* 1.1. | ||
* | ||
* @author Samuel Lissner | ||
*/ | ||
class GraylogExtendedLogFormatStructuredLogFormatter extends JsonWriterStructuredLogFormatter<ILoggingEvent> { | ||
|
||
/** | ||
* Allowed characters in field names are any word character (letter, number, | ||
* underscore), dashes and dots. | ||
*/ | ||
private static final Pattern FIELD_NAME_VALID_PATTERN = Pattern.compile("^[\\w\\.\\-]*$"); | ||
|
||
/** | ||
* Every field been sent and prefixed with an underscore "_" will be treated as an | ||
* additional field. | ||
*/ | ||
private static final String ADDITIONAL_FIELD_PREFIX = "_"; | ||
|
||
/** | ||
* Libraries SHOULD not allow to send id as additional field ("_id"). Graylog server | ||
* nodes omit this field automatically. | ||
*/ | ||
private static final Set<String> ADDITIONAL_FIELD_ILLEGAL_KEYS = Set.of("_id"); | ||
|
||
/** | ||
* Default format to be used for the `full_message` property when there is a throwable | ||
* present in the log event. | ||
*/ | ||
private static final String DEFAULT_FULL_MESSAGE_WITH_THROWABLE_FORMAT = "%s%n%n%s"; | ||
|
||
private static final PairExtractor<KeyValuePair> keyValuePairExtractor = PairExtractor | ||
.of((pair) -> makeAdditionalFieldName(pair.key), (pair) -> pair.value); | ||
|
||
GraylogExtendedLogFormatStructuredLogFormatter(Environment environment, | ||
ThrowableProxyConverter throwableProxyConverter) { | ||
super((members) -> jsonMembers(environment, throwableProxyConverter, members)); | ||
} | ||
|
||
private static void jsonMembers(Environment environment, ThrowableProxyConverter throwableProxyConverter, | ||
JsonWriter.Members<ILoggingEvent> members) { | ||
members.add("version", "1.1"); | ||
|
||
// note: a blank message will lead to a Graylog error as of Graylog v6.0.x. We are | ||
// ignoring this here. | ||
members.add("short_message", ILoggingEvent::getFormattedMessage); | ||
|
||
members.add("timestamp", ILoggingEvent::getTimeStamp) | ||
.as(GraylogExtendedLogFormatStructuredLogFormatter::formatTimeStamp); | ||
members.add("level", LevelToSyslogSeverity::convert); | ||
members.add("_level_name", ILoggingEvent::getLevel); | ||
|
||
members.add("_process_pid", environment.getProperty("spring.application.pid", Long.class)) | ||
.when(Objects::nonNull); | ||
members.add("_process_thread_name", ILoggingEvent::getThreadName); | ||
|
||
GraylogExtendedLogFormatService.get(environment).jsonMembers(members); | ||
|
||
members.add("_log_logger", ILoggingEvent::getLoggerName); | ||
|
||
members.addMapEntries(mapMDCProperties(ILoggingEvent::getMDCPropertyMap)); | ||
|
||
members.from(ILoggingEvent::getKeyValuePairs) | ||
.whenNotEmpty() | ||
.usingExtractedPairs(Iterable::forEach, keyValuePairExtractor); | ||
|
||
members.add().whenNotNull(ILoggingEvent::getThrowableProxy).usingMembers((throwableMembers) -> { | ||
throwableMembers.add("full_message", | ||
(event) -> formatFullMessageWithThrowable(throwableProxyConverter, event)); | ||
throwableMembers.add("_error_type", ILoggingEvent::getThrowableProxy).as(IThrowableProxy::getClassName); | ||
throwableMembers.add("_error_stack_trace", throwableProxyConverter::convert); | ||
throwableMembers.add("_error_message", ILoggingEvent::getThrowableProxy).as(IThrowableProxy::getMessage); | ||
}); | ||
} | ||
|
||
/** | ||
* GELF requires "seconds since UNIX epoch with optional <b>decimal places for | ||
* milliseconds</b>". To comply with this requirement, we format a POSIX timestamp | ||
* with millisecond precision as e.g. "1725459730385" -> "1725459730.385" | ||
* @param timeStamp the timestamp of the log message | ||
* @return the timestamp formatted as string with millisecond precision | ||
*/ | ||
private static double formatTimeStamp(final long timeStamp) { | ||
return new BigDecimal(timeStamp).movePointLeft(3).doubleValue(); | ||
mhalbritter marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
private static String formatFullMessageWithThrowable(final ThrowableProxyConverter throwableProxyConverter, | ||
ILoggingEvent event) { | ||
return String.format(DEFAULT_FULL_MESSAGE_WITH_THROWABLE_FORMAT, event.getFormattedMessage(), | ||
throwableProxyConverter.convert(event)); | ||
} | ||
|
||
private static Function<ILoggingEvent, Map<String, String>> mapMDCProperties( | ||
Function<ILoggingEvent, Map<String, String>> MDCPropertyMapGetter) { | ||
return MDCPropertyMapGetter.andThen((mdc) -> mdc.entrySet() | ||
.stream() | ||
.collect(Collectors.toMap((entry) -> makeAdditionalFieldName(entry.getKey()), Map.Entry::getValue))); | ||
} | ||
|
||
private static String makeAdditionalFieldName(String fieldName) { | ||
Assert.notNull(fieldName, "fieldName must not be null"); | ||
Assert.isTrue(FIELD_NAME_VALID_PATTERN.matcher(fieldName).matches(), | ||
() -> String.format("fieldName must be a valid according to GELF standard. [fieldName=%s]", fieldName)); | ||
Assert.isTrue(!ADDITIONAL_FIELD_ILLEGAL_KEYS.contains(fieldName), () -> String.format( | ||
"fieldName must not be an illegal additional field key according to GELF standard. [fieldName=%s]", | ||
fieldName)); | ||
|
||
if (fieldName.startsWith(ADDITIONAL_FIELD_PREFIX)) { | ||
// No need to prepend the `ADDITIONAL_FIELD_PREFIX` in case the caller already | ||
// has prepended the prefix. | ||
return fieldName; | ||
} | ||
|
||
return ADDITIONAL_FIELD_PREFIX + fieldName; | ||
} | ||
|
||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.