Skip to content

Fixes gh-1563 #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fixes gh-1563 #3919

wants to merge 4 commits into from

Conversation

tiarebalbi
Copy link

Simple integration of a SimpleAsyncTaskExecutor.

*/
@Configuration
@ConditionalOnClass(value = SimpleAsyncTaskExecutor.class)
@EnableConfigurationProperties(AsyncTaskExecutorProperties.class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you're creating that bean unconditionally in practice: SimpleAsyncTaskExecutor is in spring-core so it will always be available. The condition is still good IMO but you should add a condition that checks if @EnableAsync has been specified in the configuration.

Usually, when an @EnableXyz annotation is added, a post processor is registered in the context. You should look for that.

@tiarebalbi
Copy link
Author

I saw what you told about the original issue, i reviewed the other points and i'll be working to improve this implementation for than be able to resolve the original issue.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Oct 3, 2015
@philwebb
Copy link
Member

Thanks for the PR but there are complexities that we need to consider carefully before we do this. I think we'll probably try to take this on ourselves later in the year.

@philwebb philwebb closed this Jan 11, 2017
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants