Add service connection from Testcontainers Zipkin #35107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
It’s already supported in spring-boot-docker-compose, so I vote for this. Maybe you could add prometheus as well (or maybe prometheus isn't often used as a service endpoint - it scrapes apps)? |
TBH, I'm not sure but given the prometheus push configuration is already possible in spring-boot it totally makes sense to add support for service connection. I would work on this later this week but if anyone interested on contributing before that happen that would be awesome |
philwebb
added
type: enhancement
mhalbritter
pushed a commit
that referenced
this pull request
May 3, 2023
mhalbritter
added a commit
that referenced
this pull request
May 3, 2023
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.