Polish #26188
Closed
Polish #26188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: task
Closed
wilkinsona
reviewed
Apr 21, 2021
There was a problem hiding this comment.
Thanks, @izeye. I left a couple of comments for your consideration.
| @@ -6948,7 +6948,7 @@ You can use the `@DataJpaTest` annotation to test JPA applications. | |||
| By default, it scans for `@Entity` classes and configures Spring Data JPA repositories. | |||
| If an embedded database is available on the classpath, it configures one as well. | |||
| SQL queries are logged by default by setting the `spring.jpa.show-sql` property to `true`. | |||
| This can be disabled using the `showSql()` attribute of the annotation. | |||
| This can be disabled by using the `showSql()` attribute of the annotation. | |||
There was a problem hiding this comment.
I think this is OK without the "by".
There was a problem hiding this comment.
@wilkinsona I just felt that it was clearer, but it seems that my lack of knowledge on English made me feel that way. Thanks for pointing it out 😄
| @@ -54,8 +54,8 @@ | |||
| * override these settings. | |||
| * <p> | |||
| * SQL queries are logged by default by setting the {@code spring.jpa.show-sql} property | |||
| * to {@code true}. This can be disabled using the {@link DataJpaTest#showSql() showSql} | |||
| * attribute. | |||
| * to {@code true}. This can be disabled by using the {@link DataJpaTest#showSql() | |||
There was a problem hiding this comment.
I think this is OK without the "by".
|
@wilkinsona Ouch, sorry about that. Let me revisit based on your review. |
snicoll
added a commit
that referenced
this pull request
Apr 21, 2021
|
I've reworked the PR in db7460d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some typos and polishes trivial stuff.