Skip to content

Update QuartzDataSourceInitializerTests.commentPrefixCanBeCustomized to use a custom prefix that isn't covered by the default #18285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update QuartzDataSourceInitializerTests.commentPrefixCanBeCustomized to use a custom prefix that isn't covered by the default #18285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b06c36
Updated QuartzDataSourceInitializerTests.commentPrefixCanBeCustomized…
Sep 19, 2019
2089505
modified comment message
Sep 19, 2019
64d8ea5
deleted tables_h2.sql
Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../java/org/springframework/boot/autoconfigure/quartz/QuartzDataSourceInitializerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ void doubleDashIsUsedAsACommentPrefixByDefault() {
@Test
void commentPrefixCanBeCustomized() {
this.contextRunner.withUserConfiguration(TestConfiguration.class).withPropertyValues(
"spring.quartz.jdbc.comment-prefix=##",
"spring.quartz.jdbc.schema=classpath:org/springframework/boot/autoconfigure/quartz/tables_@@platform@@.sql")
"spring.quartz.jdbc.comment-prefix=**",
"spring.quartz.jdbc.schema=classpath:org/springframework/boot/autoconfigure/quartz/tables_**_comments.sql")
.run(this::assertThatDataSourceHasBeenInitialized);
}

Expand Down
4 changes: 2 additions & 2 deletions ...k/boot/autoconfigure/quartz/tables_h2.sql → ...toconfigure/quartz/tables_**_comments.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
## This is a test script to check custom comment prefix is taken into account
** This is a test script to check ** is treated as a comment prefix when prefix is customized

CREATE TABLE QRTZ_TEST_TABLE (
SCHED_NAME VARCHAR(120) NOT NULL,
CALENDAR_NAME VARCHAR (200) NOT NULL
);

## Another comment
** Another comment

COMMIT;