-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Rename WebDriverContextCustomizerFactory's customizer #36416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Could you please tell me which file name I have to rename and if provide the file path it will be helpful for me to fix this issue. |
You should try to find it by yourself, it's a basic prerequisite if you want to contribute, otherwise please don't make noise. |
I want to resolve this issue |
@quaff your comment is unnecessary. If we felt that it was necessary, @scottfrederick would have replied differently to the original question from @CodeWithSouma. |
@sbrannen I'm happy to rename this class since it's internal, but I wonder if the logging in Framework should be done at |
Thanks. I made sure it was internal before asking the team to rename it. 😉
I'd prefer not to switch to If we made that switch, many of the other "simple names" would end up considerably longer -- for example, |
Due to changes in Spring Framework 6.0 (see spring-projects/spring-framework#29229),
ContextCustomizer
implementations are logged atDEBUG
level using only their simple name.Consequently, we see log statements such as the following.
The last Customizer entry is for
org.springframework.boot.test.autoconfigure.web.servlet.WebDriverContextCustomizerFactory.Customizer
.To improve diagnostics, I suggest that the
Customizer
class be renamed toWebDriverScopeContextCustomizer
orWebDriverContextCustomizer
.The text was updated successfully, but these errors were encountered: