Adapt to HttpComponentClientHttpRequestFactory changes #32461
Assignees
Labels
status: noteworthy
A noteworthy issue to call out in the release notes
type: enhancement
A general enhancement
Milestone
Comments
bclozel
added
type: task
wilkinsona
added
type: enhancement
|
I've labeled this as an enhancement as I think we'll want it to be listed in the changelog. |
bclozel
added a commit
that referenced
this issue
Sep 29, 2022
As htttpclient 4.x is not supported anymore by `RestTemplate`, this commit changes such dependencies to httpclient5 instead. In some cases, the httpclient 4.x was transitively brought by a non-Spring dependency. See gh-32461
bclozel
added a commit
that referenced
this issue
Sep 29, 2022
This commit adapts the auto-detection of `ClientHttpRequestFactory` to look for an httpclient5 class. See gh-32461
bclozel
added a commit
that referenced
this issue
Sep 29, 2022
Prior to this commit, the `RestTemplateBuilder` would offer a generic `setReadTimeout` method to configure the read timeout on the underlying `ClientHttpRequestFactory`. This would be done in a reflective fashion, considering that all implementations align with this behavior. This option cannot be provided for HttpClient5 at the `ClientHttpRequestFactory` level anymore, so this has been deprecated in Spring Framework 6.0 and will log a warning. In order to align with our existing behavior (throwing exceptions if the option cannot be set), this commit ensures that exceptions are also thrown if the method is marked as deprecated. See gh-32461
bclozel
added a commit
that referenced
this issue
Sep 29, 2022
This commit adapts the `TestRestTemplate` implementation to the httpclient5 API since httpclient 4.x is now unsupported in Spring Framework. See gh-32461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of spring-projects/spring-framework#28925, Spring Framework doesn't configure the Apache HttpComponents client 4.x, as this generation is not maintained anymore. The implementation has switched to using the httpclient5 generation.
Besides adapting our auto-configuration and various tests, we also need to consider:
RestTemplateBuilderin light of the deprecation of thesetReadTimeoutmethod on the request factoryThe 5.1.x documentation has interesting bits of documentation about migrating to the "classic" API as well as typical client usage examples.
This change should be reflected in our own migration guide.
The text was updated successfully, but these errors were encountered: