-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Allow to set loadOnStartup on actuator EndpointServlet's #15672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
status: superseded
An issue that has been superseded by another
type: enhancement
A general enhancement
Comments
I think an attribute for configuring |
@wilkinsona if not already taken can I work on this issue? |
Thank you for the offer. I'd like to give @juliojgd a little while to prepare something if they're still interested in doing so. Let's give them a week or so and see where we are. |
Still interested. Working on it. |
juliojgd
pushed a commit
to juliojgd/spring-boot
that referenced
this issue
Feb 27, 2019
loadOnStartup property was missing from EndpointServlet and cannot be set inside ServletEndpointRegistrar. Now it can be set and register a Servlet with that integer property ready to act upon registration Fixes spring-projects#15672
Closing in favour of #16053. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: superseded
An issue that has been superseded by another
type: enhancement
A general enhancement
spring-boot/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/web/ServletEndpointRegistrar.java
Lines 73 to 78 in badccc0
Why is setting loadOnStartup not allowed in ServletEndpointRegistrar?
In my specific use case I need that the invocation of 'init' method in wrapped Servlet instance be on startup, not in the first http invocation.
Is there a reason to not provide this option for EndPointServlet's?
To provide it, org.springframework.boot.actuate.endpoint.web.EndpointServlet should contain a property 'loadOnStartup' in addition to already present 'initParameters' property. If there is no reason to not do it, I can provide a PR.
Thanks for answering.
The text was updated successfully, but these errors were encountered: