Skip to content

Commit e924745

Browse files
committed
Start building against Spring Data Moore M2 snapshots
See gh-15197
1 parent c25b165 commit e924745

File tree

3 files changed

+16
-37
lines changed

3 files changed

+16
-37
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/data/jdbc/JdbcRepositoriesAutoConfiguration.java

Lines changed: 10 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2018 the original author or authors.
2+
* Copyright 2012-2019 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -16,8 +16,6 @@
1616

1717
package org.springframework.boot.autoconfigure.data.jdbc;
1818

19-
import java.util.Optional;
20-
2119
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
2220
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2321
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
@@ -27,29 +25,28 @@
2725
import org.springframework.boot.autoconfigure.jdbc.JdbcTemplateAutoConfiguration;
2826
import org.springframework.context.annotation.Configuration;
2927
import org.springframework.context.annotation.Import;
30-
import org.springframework.data.jdbc.core.convert.JdbcCustomConversions;
28+
import org.springframework.data.jdbc.repository.config.AbstractJdbcConfiguration;
3129
import org.springframework.data.jdbc.repository.config.EnableJdbcRepositories;
3230
import org.springframework.data.jdbc.repository.config.JdbcConfiguration;
3331
import org.springframework.data.jdbc.repository.config.JdbcRepositoryConfigExtension;
34-
import org.springframework.data.relational.core.conversion.RelationalConverter;
35-
import org.springframework.data.relational.core.mapping.NamingStrategy;
36-
import org.springframework.data.relational.core.mapping.RelationalMappingContext;
3732
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcOperations;
3833

3934
/**
4035
* {@link EnableAutoConfiguration Auto-configuration} for Spring Data's JDBC Repositories.
4136
* <p>
4237
* Once in effect, the auto-configuration is the equivalent of enabling JDBC repositories
43-
* using the {@link EnableJdbcRepositories} annotation and providing a
44-
* {@link JdbcConfiguration} subclass.
38+
* using the {@link EnableJdbcRepositories} annotation and providing an
39+
* {@link AbstractJdbcConfiguration} subclass.
4540
*
4641
* @author Andy Wilkinson
4742
* @since 2.1.0
4843
* @see EnableJdbcRepositories
4944
*/
45+
@SuppressWarnings("deprecation")
5046
@Configuration
5147
@ConditionalOnBean(NamedParameterJdbcOperations.class)
52-
@ConditionalOnClass({ NamedParameterJdbcOperations.class, JdbcConfiguration.class })
48+
@ConditionalOnClass({ NamedParameterJdbcOperations.class,
49+
AbstractJdbcConfiguration.class })
5350
@ConditionalOnProperty(prefix = "spring.data.jdbc.repositories", name = "enabled", havingValue = "true", matchIfMissing = true)
5451
@AutoConfigureAfter(JdbcTemplateAutoConfiguration.class)
5552
public class JdbcRepositoriesAutoConfiguration {
@@ -62,27 +59,9 @@ static class JdbcRepositoriesConfiguration {
6259
}
6360

6461
@Configuration
65-
@ConditionalOnMissingBean(JdbcConfiguration.class)
66-
static class SpringBootJdbcConfiguration extends JdbcConfiguration {
67-
68-
// Remove these public methods when they are made
69-
// public in Spring Data
70-
@Override
71-
public JdbcCustomConversions jdbcCustomConversions() {
72-
return super.jdbcCustomConversions();
73-
}
74-
75-
@Override
76-
public RelationalMappingContext jdbcMappingContext(
77-
Optional<NamingStrategy> namingStrategy) {
78-
return super.jdbcMappingContext(namingStrategy);
79-
}
80-
81-
@Override
82-
public RelationalConverter relationalConverter(
83-
RelationalMappingContext mappingContext) {
84-
return super.relationalConverter(mappingContext);
85-
}
62+
@ConditionalOnMissingBean({ AbstractJdbcConfiguration.class,
63+
JdbcConfiguration.class })
64+
static class SpringBootJdbcConfiguration extends AbstractJdbcConfiguration {
8665

8766
}
8867

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/jdbc/JdbcRepositoriesAutoConfigurationTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2018 the original author or authors.
2+
* Copyright 2012-2019 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -30,8 +30,8 @@
3030
import org.springframework.boot.autoconfigure.jdbc.JdbcTemplateAutoConfiguration;
3131
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
3232
import org.springframework.context.annotation.Configuration;
33+
import org.springframework.data.jdbc.repository.config.AbstractJdbcConfiguration;
3334
import org.springframework.data.jdbc.repository.config.EnableJdbcRepositories;
34-
import org.springframework.data.jdbc.repository.config.JdbcConfiguration;
3535
import org.springframework.data.jdbc.repository.config.JdbcRepositoryConfigExtension;
3636
import org.springframework.data.repository.Repository;
3737

@@ -78,7 +78,7 @@ public void basicAutoConfiguration() {
7878
"spring.datasource.data=classpath:city.sql",
7979
"spring.datasource.generate-unique-name:true")
8080
.run((context) -> {
81-
assertThat(context).hasSingleBean(JdbcConfiguration.class);
81+
assertThat(context).hasSingleBean(AbstractJdbcConfiguration.class);
8282
assertThat(context).hasSingleBean(CityRepository.class);
8383
assertThat(context.getBean(CityRepository.class).findById(2000L))
8484
.isPresent();
@@ -93,7 +93,7 @@ public void autoConfigurationWithNoRepositories() {
9393
.withUserConfiguration(EmbeddedDataSourceConfiguration.class,
9494
EmptyConfiguration.class)
9595
.run((context) -> {
96-
assertThat(context).hasSingleBean(JdbcConfiguration.class);
96+
assertThat(context).hasSingleBean(AbstractJdbcConfiguration.class);
9797
assertThat(context).doesNotHaveBean(Repository.class);
9898
});
9999
}
@@ -111,7 +111,7 @@ public void honoursUsersEnableJdbcRepositoriesConfiguration() {
111111
"spring.datasource.data=classpath:city.sql",
112112
"spring.datasource.generate-unique-name:true")
113113
.run((context) -> {
114-
assertThat(context).hasSingleBean(JdbcConfiguration.class);
114+
assertThat(context).hasSingleBean(AbstractJdbcConfiguration.class);
115115
assertThat(context).hasSingleBean(CityRepository.class);
116116
assertThat(context.getBean(CityRepository.class).findById(2000L))
117117
.isPresent();

spring-boot-project/spring-boot-dependencies/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@
166166
<spring-amqp.version>2.1.4.BUILD-SNAPSHOT</spring-amqp.version>
167167
<spring-batch.version>4.1.1.RELEASE</spring-batch.version>
168168
<spring-cloud-connectors.version>2.0.4.RELEASE</spring-cloud-connectors.version>
169-
<spring-data-releasetrain.version>Lovelace-BUILD-SNAPSHOT</spring-data-releasetrain.version>
169+
<spring-data-releasetrain.version>Moore-BUILD-SNAPSHOT</spring-data-releasetrain.version>
170170
<spring-framework.version>${spring.version}</spring-framework.version>
171171
<spring-hateoas.version>0.25.0.RELEASE</spring-hateoas.version>
172172
<spring-integration.version>5.1.3.BUILD-SNAPSHOT</spring-integration.version>

0 commit comments

Comments
 (0)