Skip to content

Commit 2114744

Browse files
committed
Polish "Add support for partitioned cookies"
See gh-42316
1 parent 4a1676d commit 2114744

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/servlet/server/AbstractServletWebServerFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
public abstract class AbstractServletWebServerFactory extends AbstractConfigurableWebServerFactory
6161
implements ConfigurableServletWebServerFactory {
6262

63-
static final String PARTITIONED_ATTRIBUTE_NAME = "Partitioned";
63+
private static final String PARTITIONED_ATTRIBUTE_NAME = "Partitioned";
6464

6565
protected final Log logger = LogFactory.getLog(getClass());
6666

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/servlet/server/AbstractServletWebServerFactoryTests.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -873,8 +873,7 @@ void sessionCookieConfiguration() {
873873
assertThat(sessionCookieConfig.getPath()).isEqualTo("/testpath");
874874
assertThat(sessionCookieConfig.isHttpOnly()).isTrue();
875875
assertThat(sessionCookieConfig.isSecure()).isTrue();
876-
assertThat(sessionCookieConfig.getAttribute(AbstractServletWebServerFactory.PARTITIONED_ATTRIBUTE_NAME))
877-
.isEqualTo("true");
876+
assertThat(sessionCookieConfig.getAttribute("Partitioned")).isEqualTo("true");
878877
assertThat(sessionCookieConfig.getMaxAge()).isEqualTo(60);
879878
}
880879

@@ -1182,8 +1181,7 @@ void sessionConfiguration() {
11821181
assertThat(servletContext.getSessionCookieConfig().isHttpOnly()).isTrue();
11831182
assertThat(servletContext.getSessionCookieConfig().isSecure()).isTrue();
11841183
assertThat(servletContext.getSessionCookieConfig().getMaxAge()).isEqualTo(60);
1185-
assertThat(servletContext.getSessionCookieConfig()
1186-
.getAttribute(AbstractServletWebServerFactory.PARTITIONED_ATTRIBUTE_NAME)).isEqualTo("false");
1184+
assertThat(servletContext.getSessionCookieConfig().getAttribute("Partitioned")).isEqualTo("false");
11871185
}
11881186

11891187
@Test

0 commit comments

Comments
 (0)