Introducing MultiRabbit Bootstrap #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rwanderc
commented
Jan 31, 2021
rwanderc
commented
- Creation of the MultiRabbitBootstrapConfiguration, activated via properties, since the default RabbitListenerBPP bean cannot be overridden with auto-config.
- Injection of the MultiRabbit admin to the RabbitListener, before it's processed by RabbitListenerBPP, so as to have the bean resolved and assigned to the MethodRabbitListenerEndpoint. It fixes an issue lately found on the order of loading where the MultiRabbitAutoConfig (at boot) was not being processed before MultiRabbitBPP starts the postProcessAfterInitialization(), which leads to bean not found.
- Move some configs to RabbitListenerConfigUtils as they are shared among Rabbit and MultiRabbit, as well as used in the boot.
…o register MultiRabbitBPP
…olved for the RabbitListenerEndpoint
rwanderc
commented
Jan 31, 2021
.../main/java/org/springframework/amqp/rabbit/annotation/MultiRabbitBootstrapConfiguration.java
Show resolved
Hide resolved
garyrussell
reviewed
Feb 1, 2021
...g-rabbit/src/main/java/org/springframework/amqp/rabbit/config/RabbitListenerConfigUtils.java
Show resolved
Hide resolved
garyrussell
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.