Add a missing getter to the CategoryScores class #2939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jonghoon park <[email protected]>
|
@dev-jonghoonpark Thanks for adding the missing getters. |
Comment on lines
+67
to
+75
| assertThat(scores.getSexual()).isNotNull(); | ||
| assertThat(scores.getHate()).isNotNull(); | ||
| assertThat(scores.getViolence()).isNotNull(); | ||
| assertThat(scores.getDangerousAndCriminalContent()).isNotNull(); | ||
| assertThat(scores.getSelfHarm()).isNotNull(); | ||
| assertThat(scores.getHealth()).isNotNull(); | ||
| assertThat(scores.getFinancial()).isNotNull(); | ||
| assertThat(scores.getLaw()).isNotNull(); | ||
| assertThat(scores.getPii()).isNotNull(); |
There was a problem hiding this comment.
This part is essentially a test that will always pass because the return type of the getters is a primitive type. However, I believe it's worth keeping to ensure the presence of the getters.
The same approach is applied in the OpenAiModerationModelIT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #2919
In spring-projects/spring-ai#2201
properties related to the response values of Mistral AI's Moderation API were added to the CategoryScores class. However, getters for user access were not provided.
So, I have added them.
Additional discussion required:
spring-ai-model/src/main/java/org/springframework/ai/moderation/Categories.javaspring-ai-model/src/main/java/org/springframework/ai/moderation/CategoryScores.javaThese two classes seem to need to encapsulate common parts, but currently, they contain detailed information for both OpenAI and Mistral.
It seems that an appropriate separation process is necessary.