-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Anthropic extended thinking #2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
apappascs
wants to merge
2
commits into
spring-projects:main
from
apappascs:feature/anthropic-thinking
Closed
feat: Anthropic extended thinking #2315
apappascs
wants to merge
2
commits into
spring-projects:main
from
apappascs:feature/anthropic-thinking
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d387cf
to
9168278
Compare
birariro
reviewed
Feb 28, 2025
...s/spring-ai-anthropic/src/main/java/org/springframework/ai/anthropic/AnthropicChatModel.java
Outdated
Show resolved
Hide resolved
4eb24fd
to
9702cc9
Compare
- The `thinking` option is added to `AnthropicChatOptions` and `ChatCompletionRequest`. - The `AnthropicApi` and `AnthropicChatModel` now handle `THINKING` and `REDACTED_THINKING` content blocks in responses. New tests verify parsing of these blocks. - Updated method signatures on ChatCompletionRequestBuilder, deprecating old builders with `with*` prefix in favor of those without. Signed-off-by: Alexandros Pappas <[email protected]>
Signed-off-by: Alexandros Pappas <[email protected]>
9702cc9
to
0b172cf
Compare
Any ETA on this? |
just going through the backlog now, will be part of M7. Thanks, this is a very nice contribution! |
Bumping to RC :( sorry about that. |
Thank you @apappascs |
I'm hitting this error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thinking
option is added toAnthropicChatOptions
andChatCompletionRequest
.AnthropicApi
andAnthropicChatModel
now handleTHINKING
andREDACTED_THINKING
content blocks in responses. New tests verify parsing of these blocks.with*
prefix in favor of those without.more details:
Local testing: