Skip to content

Unclosed Span in ribbon client #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dsyer opened this issue Mar 31, 2016 · 4 comments
Closed

Unclosed Span in ribbon client #240

dsyer opened this issue Mar 31, 2016 · 4 comments
Milestone
1.0.0.RC2

Comments

@dsyer
Copy link
Contributor

dsyer commented Mar 31, 2016

This one is hard to reproduce I think, but @joshlong had a sample where there were WARN logs about uncloseable spans from a Ribbon client that couldn't resolve its server. It was using Feign as well.
@marcingrzejszczak
Copy link
Contributor

marcingrzejszczak commented Mar 31, 2016 via email

@dsyer
Copy link
Contributor Author

dsyer commented Mar 31, 2016

I think I did it. If I use Feign and Ribbon/Hystrix and don't define a server list I can break the ribbon sample in Sleuth.

dsyer pushed a commit that referenced this issue Mar 31, 2016
Add Feign sample that fails to close a span
84f4d37 
See gh-240
@dsyer
Copy link
Contributor Author

dsyer commented Mar 31, 2016

Commit 84f4d37 adds a sample that fails (e.g. run it and curl localhost:3383/).

@dsyer dsyer modified the milestone: 1.0.0.RC2 Mar 31, 2016
@dsyer
Copy link
Contributor Author

dsyer commented Apr 1, 2016

I have a test that fails and I can fix it, but it won't run in a suite because of some stale state from one of the other tests. Needs more work.

@dsyer dsyer closed this as completed in 72e1e6d Apr 1, 2016
shivangshah pushed a commit to shivangshah/spring-cloud-sleuth that referenced this issue Apr 1, 2016
Add Feign sample that fails to close a span
9cf49df 
See spring-cloudgh-240
shivangshah pushed a commit to shivangshah/spring-cloud-sleuth that referenced this issue Apr 1, 2016
Ensure span is cleaned up if Feign client throws a non retryable
4cf2fb5 
The retryable case was already covered and tested but if the exception
is not retryable, we need to rethrow and clean up the thread state.

Fixes spring-cloudgh-240
shivangshah pushed a commit to shivangshah/spring-cloud-sleuth that referenced this issue Apr 1, 2016
Add Feign sample that fails to close a span
7b11f4c 
See spring-cloudgh-240
shivangshah pushed a commit to shivangshah/spring-cloud-sleuth that referenced this issue Apr 1, 2016
Ensure span is cleaned up if Feign client throws a non retryable
3bc1283 
The retryable case was already covered and tested but if the exception
is not retryable, we need to rethrow and clean up the thread state.

Fixes spring-cloudgh-240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0.RC2
Development

No branches or pull requests
2 participants
@dsyer @marcingrzejszczak